[S] Change in coreboot[master]: pc80/i8254: Add speaker beep function - coreboot-gerrit

13 Jan 2023


      Attention is currently required from: Paul Menzel, Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68100 )
Change subject: pc80/i8254: Add speaker beep function
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/pc80/pc/i8254.c:
https://review.coreboot.org/c/coreboot/+/68100/comment/4de4bbf1_7282f1a0 
PS5, Line 115: frequency
...
Add the unit Hz?
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68100
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8189b3462bb5140af352fa786db3a6a2a45076f2
Gerrit-Change-Number: 68100
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 13 Jan 2023 16:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment