Attention is currently required from: Paul Menzel, Yu-Ping Wu. Jg Daolongzhu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51024 )
Change subject: WIP: soc/mediatek/mt8192: adjust i2c tLOW, tSU,STO ......................................................................
Patch Set 9:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51024/comment/abd783f0_fa230e4a PS5, Line 2: jg_daolongzhu
Please use *Jg Daolongzhu*.
Done
https://review.coreboot.org/c/coreboot/+/51024/comment/383a8273_269b4f0f PS5, Line 7: tLOW,tSU,STO
Please add a space after the comma.
Done
https://review.coreboot.org/c/coreboot/+/51024/comment/2af901b6_9a5e8334 PS5, Line 8:
Please describe the problem first.
Done
https://review.coreboot.org/c/coreboot/+/51024/comment/ed0b55da_371357bf PS5, Line 9: 1.adjust
Please add a space after the dot.
Done
https://review.coreboot.org/c/coreboot/+/51024/comment/49083518_237524c0 PS5, Line 10: to adjust tLOW.
This fits on one line.
Done
https://review.coreboot.org/c/coreboot/+/51024/comment/2a23a48f_198f04e5 PS5, Line 14: asurada(MT8192)
Please add a space before the (.
Done
-
Jg Daolongzhu (Code Review)