Attention is currently required from: Name of user not set #1004406.
Alicja Michalska has posted comments on this change by Name of user not set #1004406. ( https://review.coreboot.org/c/coreboot/+/65225?usp=email )
Change subject: mb/asrock: Add ASRock H370m-ITX support (Coffee Lake) ......................................................................
Patch Set 20:
(5 comments)
Patchset:
PS20: Hi!
File src/mainboard/asrock/h370m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/65225/comment/6c4d02e9_4e94c35c?usp... : PS20, Line 6: register "s0ix_enable" = "1" Try disabling it, platform might suspend correctly if you use S3 state instead
https://review.coreboot.org/c/coreboot/+/65225/comment/0f77075e_10ccbaa1?usp... : PS20, Line 14: device ref igpu on end Did you forget to include DDI configuration? Boot Linux with `drm.debug=0xe` kernel parameter and configure them according to VBT configuration.
https://review.coreboot.org/c/coreboot/+/65225/comment/57388f37_2bace93a?usp... : PS20, Line 59: device ref sata on Check your GPIO config against Intel's PCH documentaton
https://review.coreboot.org/c/coreboot/+/65225/comment/1c51a956_771f600a?usp... : PS20, Line 115: device ref lpc_espi on You can obtain a copy of datasheet for SuperIO from Nuvoton if you send them an email. This will allow you to add support for it, have RS232 port, suspend and fan control working.
-
Alicja Michalska (Code Review)