[M] Change in coreboot[master]: mb/google/corsola: Report SKU and panel ID for unprovisioned devices
Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin, cong yang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74135 )
Change subject: mb/google/corsola: Report SKU and panel ID for unprovisioned devices ......................................................................
Patch Set 6:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74135/comment/0db2fab0_f1ca8218 PS6, Line 9: mipi MIPI
https://review.coreboot.org/c/coreboot/+/74135/comment/241433f9_de4ce33b PS6, Line 10: mipi panel MIPI panels
Patchset:
PS5:
Done, but this changed is not verified since I haven't got the starmie board yet..
Then let's keep this open until this patch is tested.
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/74135/comment/fca8e69b_75812e1c PS6, Line 79: adc_voltages_table = adc_voltages_detachable; Just `voltages = adc_voltages_detachable[channel]` here and no need for `adc_voltages_table`.
https://review.coreboot.org/c/coreboot/+/74135/comment/9935bf15_9ddfc131 PS6, Line 113: if (cached_sku_code == BOARD_ID_INIT) { Since the logic becomes complicated, let's return here if `cached_sku_code != BOARD_ID_INIT`. Then one indentation level could be saved for the following code.
https://review.coreboot.org/c/coreboot/+/74135/comment/6c294cfc_c4290ac1 PS6, Line 116: #if (CONFIG(BOARD_GOOGLE_STARMIE_COMMON)) Use `if (CONFIG(BOARD_GOOGLE_STARMIE_COMMON))
https://review.coreboot.org/c/coreboot/+/74135/comment/19cd95f8_0dff78a3 PS6, Line 126: if (cached_sku_code == CROS_SKU_UNKNOWN) { I think we can also add `cached_sku_code == CROS_SKU_UNPROVISIONED` here, so that the "if" statements could be merged.
-
Yu-Ping Wu (Code Review)