HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32032 )
Change subject: nb/intel/i945: Use DEBUG_RAM_SETUP
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32032/1/src/mainboard/ibase/mb899/romstage.c
File src/mainboard/ibase/mb899/romstage.c:
https://review.coreboot.org/#/c/32032/1/src/mainboard/ibase/mb899/romstage.c...
PS1, Line 234: if (CONFIG(DEBUG_RAM_SETUP))
: dump_spd_registers();
do we really need to dump MCHBAR at this stage ?
some of registers may be affected by this reading ?
we probably need to split it :
1- debug/dump SPD (here it makes sense
2- debug/dump MCHBAR (but, I think, not here)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32032
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib952b8905c29a5c5c289027071eb6ff59aaa330b
Gerrit-Change-Number: 32032
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 24 Mar 2019 08:56:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment