Attention is currently required from: Paul Menzel.
Nicholas Sudsgaard has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/84414?usp=email )
Change subject: mb/google: Correct number of jacks in hda_verb.c
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84414/comment/8535d360_de845b14?usp... :
PS1, Line 10:
Mention both boards in the commit message, and say, that they were one too small?
I think it's not necessary to mention the specific change in size, but I have noted that I added some padding values.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84414?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id377281af310642a6ba77e5a0002ca1dfca38827
Gerrit-Change-Number: 84414
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 21 Sep 2024 15:01:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org