James has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31364
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
mb/lenovo/x131e: enable mSATA slot
Per google/stout. Functionality untested.
Change-Id: I7cc9837f572236acac2007e95990e64c25a5d6e2 --- M src/mainboard/lenovo/x131e/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31364/1
diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index 628c4eb..d20abdf 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -49,8 +49,8 @@ register "gpi6_routing" = "2" register "gpi13_routing" = "2"
- # Enable SATA ports - register "sata_port_map" = "0x1" + # Enable SATA ports 0 (2.5 inch) and 1 (mSATA) + register "sata_port_map" = "0x3" # Set max SATA speed to 6.0 Gb/s register "sata_interface_speed_support" = "0x3"
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31364
to look at the new patch set (#2).
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
mb/lenovo/x131e: enable mSATA slot
Per google/stout. Functionality untested.
Change-Id: I7cc9837f572236acac2007e95990e64c25a5d6e2 Signed-off-by: James Ye jye836@gmail.com --- M src/mainboard/lenovo/x131e/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31364/2
James has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/31364 )
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
Removed reviewer Paul Menzel.
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31364 )
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
Patch Set 2: Code-Review+2
James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31364 )
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
Patch Set 2:
I have since tested the functionality since I published this patch and it does work. Should I amend the commit message?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31364 )
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
Patch Set 2: Code-Review+1
Patch Set 2:
I have since tested the functionality since I published this patch and it does work. Should I amend the commit message?
Yes, please do so. The scores should stay the same, if you just edit the commit message.
Hello Alexander Couzens, Patrick Rudolph, Angel Pons, Arthur Heymans, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31364
to look at the new patch set (#3).
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
mb/lenovo/x131e: enable mSATA slot
Per google/stout.
Tested with SanDisk SSD U110.
Change-Id: I7cc9837f572236acac2007e95990e64c25a5d6e2 Signed-off-by: James Ye jye836@gmail.com --- M src/mainboard/lenovo/x131e/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31364/3
James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31364 )
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
Patch Set 3:
Patch Set 2: Code-Review+1
Patch Set 2:
I have since tested the functionality since I published this patch and it does work. Should I amend the commit message?
Yes, please do so. The scores should stay the same, if you just edit the commit message.
Hm, did rebasing the patch wipe the review scores out? Oops.
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31364 )
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
Patch Set 3: Code-Review+2
Alexander Couzens has submitted this change. ( https://review.coreboot.org/c/coreboot/+/31364 )
Change subject: mb/lenovo/x131e: enable mSATA slot ......................................................................
mb/lenovo/x131e: enable mSATA slot
Per google/stout.
Tested with SanDisk SSD U110.
Change-Id: I7cc9837f572236acac2007e95990e64c25a5d6e2 Signed-off-by: James Ye jye836@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31364 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Alexander Couzens lynxis@fe80.eu --- M src/mainboard/lenovo/x131e/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Alexander Couzens: Looks good to me, approved
diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index 2a98a60..2d15d87 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -49,8 +49,8 @@ register "gpi6_routing" = "2" register "gpi13_routing" = "2"
- # Enable SATA ports - register "sata_port_map" = "0x1" + # Enable SATA ports 0 (2.5 inch) and 1 (mSATA) + register "sata_port_map" = "0x3" # Set max SATA speed to 6.0 Gb/s register "sata_interface_speed_support" = "0x3"
-
Alexander Couzens (Code Review) -
James (Code Review)
-
Paul Menzel (Code Review)