Change in coreboot[master]: soc/mediatek/mt8186: Add GPIO driving functions - coreboot-gerrit

8 Mar 2022


      Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62471 )
Change subject: soc/mediatek/mt8186: Add GPIO driving functions
......................................................................
Patch Set 11:
(1 comment)
File src/soc/mediatek/mt8186/gpio.c:
https://review.coreboot.org/c/coreboot/+/62471/comment/92316629_bde0a167 
PS11, Line 202: Omitted entries are all zero, same as GPIO_DRV_INFO_NOT_IMPLEMENTED
...
Unimplemented GPIOs are intentionally omitted here with shift=0
should be width=0?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62471
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d987f28be98b515fa5c542222bda08bea1d5118
Gerrit-Change-Number: 62471
Gerrit-PatchSet: 11
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Tue, 08 Mar 2022 02:26:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment