Attention is currently required from: Arthur Heymans, Bao Zheng, Felix Held, Marshall Dawson, Martin L Roth, Martin Roth.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76498?usp=email )
Change subject: soc/amd/genoa: Add Kconfig/Makefile to generate PSP image
......................................................................
Patch Set 10:
(2 comments)
File src/soc/amd/genoa/Kconfig:
https://review.coreboot.org/c/coreboot/+/76498/comment/53a98795_8692706f :
PS9, Line 111: site-local/3rdparty/amd_blobs_internal
We probably want to update this and the SPL_TABLE_FILE to not point into site-local.
Done
File src/soc/amd/genoa/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76498/comment/4153d6b8_2cc81f58 :
PS9, Line 127: GENOA_FWM_POSITION
rebase to main and it should be changed to […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76498?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I95d84f93663a80f322fd4d7cdeb35ccfe0ec7d21
Gerrit-Change-Number: 76498
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bao Zheng
fishbaozi@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 27 Sep 2023 16:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment