Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 36:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40581/34/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40581/34/src/mainboard/clevo/cml-u/... PS34, Line 7: /* : * TODO: : * - Add kill switches for WLAN, BT, LTE, CCD : * - Add support for WoL (LAN, WLAN) : * - Make M.2 port configurable (SATA <> PCIe) : * - Make SATA DevSlp configurable : * - Make TBT port configurable (TBT <> DisplayPort) : */
generally this is less than ideal unless there's a specific reason these haven't been implemented
In my opinion, to-dos can be fixed in follow-ups. If a device is able to run a payload that state could go into the master branch.