Attention is currently required from: Hung-Te Lin, Paul Menzel. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60386 )
Change subject: mb/google/corsola: Fully calibrate DRAM ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60386/comment/f4337632_c80d90b5 PS3, Line 9: Initialize and calibrate DRAM in romstage.
Without full calibration (basic(?)), did the board boot?
No, if we not do full dram calibration, the stage will pause on romstage. Because we failed to do dram calibration, dram will failed to be used and will not go to ramstage.
Commit Message:
https://review.coreboot.org/c/coreboot/+/60386/comment/4e30c30c_02e70d64 PS4, Line 13: 20014 msecs
That’s 20 seconds, wow! […]
because we have dumped the logs, so it will cause so many time. If we close uart dump, it will be a proper number.
-
Rex-BC Chen (Code Review)