Change in ...coreboot[master]: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYP...

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

mikeb mikeb (Code Review)

3 Feb 2019 3 Feb '19

4:02 p.m.

Hello Mike Banon,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/31222

to review the following change.

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................

drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP

Intel PCI-e WiFi adapters are rare outside of laptops. DRIVERS_INTEL_WIFI should not be selected by default if the mainboard is not a laptop.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I9a7e5cd515da4ee4c4176227eea2e863ed55c420 --- M src/drivers/intel/wifi/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/31222/1

diff --git a/src/drivers/intel/wifi/Kconfig b/src/drivers/intel/wifi/Kconfig index 4dc4d7f..80a7ef8 100644 --- a/src/drivers/intel/wifi/Kconfig +++ b/src/drivers/intel/wifi/Kconfig @@ -1,7 +1,7 @@ config DRIVERS_INTEL_WIFI bool "Support Intel PCI-e WiFi adapters" depends on ARCH_X86 - default y if PCIEXP_PLUGIN_SUPPORT + default y if PCIEXP_PLUGIN_SUPPORT && !SYSTEM_TYPE_LAPTOP help When enabled, add identifiers in ACPI and SMBIOS tables to make OS drivers work with certain Intel PCI-e WiFi chipsets.

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

mikeb mikeb (Code Review)

3 Feb 3 Feb

4:23 p.m.

Hello Patrick Rudolph, Mike Banon, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31222

to look at the new patch set (#2).

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................

drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP

Intel PCI-e WiFi adapters are rare outside of laptops. DRIVERS_INTEL_WIFI should not be selected by default if the mainboard is not a laptop.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I9a7e5cd515da4ee4c4176227eea2e863ed55c420 --- M src/drivers/intel/wifi/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/31222/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a7e5cd515da4ee4c4176227eea2e863ed55c420 Gerrit-Change-Number: 31222 Gerrit-PatchSet: 2 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-MessageType: newpatchset

mikeb mikeb (Code Review)

4:24 p.m.

Hello Patrick Rudolph, Mike Banon, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31222

to look at the new patch set (#3).

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................

drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP

Intel PCI-e WiFi adapters are rare outside of laptops. DRIVERS_INTEL_WIFI should not be selected by default if the mainboard is not a laptop.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I9a7e5cd515da4ee4c4176227eea2e863ed55c420 --- M src/drivers/intel/wifi/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/31222/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a7e5cd515da4ee4c4176227eea2e863ed55c420 Gerrit-Change-Number: 31222 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-MessageType: newpatchset

mikeb mikeb (Code Review)

4:37 p.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31222 )

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................

Patch Set 4:

Sorry I fixed my mistake (should've been "default y if PCIEXP_PLUGIN_SUPPORT && SYSTEM_TYPE_LAPTOP" without any ! ) and Jenkins failed a couple of times, but it is ready now

-- To view, visit https://review.coreboot.org/c/coreboot/+/31222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a7e5cd515da4ee4c4176227eea2e863ed55c420 Gerrit-Change-Number: 31222 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-Comment-Date: Sun, 03 Feb 2019 19:37:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

5:01 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31222 )

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................

Patch Set 4:

What about Chromeboxes and the like? they often come with wifi. If your intention isn't some honest inves- tigation into every board in the tree if this option makes sense or not, it looks like your only incentive is user patronizing?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a7e5cd515da4ee4c4176227eea2e863ed55c420 Gerrit-Change-Number: 31222 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-Comment-Date: Sun, 03 Feb 2019 20:01:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

7:51 p.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31222 )

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................

Patch Set 4:

...

Patch Set 4:

What about Chromeboxes and the like? they often come with wifi. If your intention isn't some honest inves- tigation into every board in the tree if this option makes sense or not, it looks like your only incentive is user patronizing?

Sorry, I forgot there are Chromeboxes and other "MiniPC" computers which could have a MiniPCIe slot while not belonging to SYSTEM_TYPE_LAPTOP class. I'm going to look at coreboot-supporting boards to see their technical specs and if I could improve/expand this "default y if" option or not; marking this change as WIP meanwhile...

-- To view, visit https://review.coreboot.org/c/coreboot/+/31222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a7e5cd515da4ee4c4176227eea2e863ed55c420 Gerrit-Change-Number: 31222 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-Comment-Date: Sun, 03 Feb 2019 22:51:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

8 Mar 8 Mar

3:12 p.m.

mikeb mikeb has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31222 )

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................

Abandoned

Abandoned for the same reasons as CB:31308

-- To view, visit https://review.coreboot.org/c/coreboot/+/31222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a7e5cd515da4ee4c4176227eea2e863ed55c420 Gerrit-Change-Number: 31222 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1944

days inactive

1977

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

mikeb mikeb (Code Review)
Nico Huber (Code Review)