Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62506 )
Change subject: libpayload: cbmem_console: Drop loglevel markers from snapshot
......................................................................
Patch Set 2:
(1 comment)
File payloads/libpayload/drivers/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/62506/comment/4fbce47c_c17fa469
PS1, Line 120: /* Slight memory corruption may occur between reboots and give us a few
: unprintable characters like '\0'. Replace them with '?' on output. */
: for (cursor = 0; cursor < size; cursor++)
: if (!isprint(console_c[cursor]) && !isspace(console_c[cursor]))
: console_c[cursor] = '?';
to add an argument to this function (bool keep_markers)
I'm fine with that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62506
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a9e5d464508320cf43ea572d62896d38c2a128d
Gerrit-Change-Number: 62506
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 08 Mar 2022 03:07:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment