Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69429 )
Change subject: amdfwtool: Set the base address of AMDFW as relative ......................................................................
Patch Set 2:
(7 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/42c80e63_6f9f95f8 PS2, Line 2294: case 0: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/c30a768b_879844e8 PS2, Line 2295: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/4fe2a625_ac09b6ad PS2, Line 2296: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/5db7f1a0_248495c1 PS2, Line 2297: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/0bd288f2_01bbc677 PS2, Line 2298: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/d8915a49_1bf88d98 PS2, Line 2299: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/5af91aa1_9d97eec1 PS2, Line 2300: case 0x020000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
-
build bot (Jenkins) (Code Review)