Attention is currently required from: Michał Żygowski. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63501 )
Change subject: soc/intel/alderlake/retimer.c: Do not access TCSS devices on ADL-S ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Why not just modify the Makefile, e.g.
``` + +ifneq ($(SOC_INTEL_ALDERLAKE_PCH_S,y) ramstage-y += retimer.c +endif ramstage-y += soundwire.c ramstage-y += systemagent.c ramstage-y += tcss.c ```
It's likely that ADL-S boards would not include the DRIVERS_INTEL_USB4_RETIMER Kconfig option, so this retimer function is not needed in that case anyway.