Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Hello Hope Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/85799?usp=email
to review the following change.
Change subject: soc/mediatek/mt8196: Add delay in pmif_spmi.c ......................................................................
soc/mediatek/mt8196: Add delay in pmif_spmi.c
The initialization process of SPMI requires a certain amount of time (0.5ms) to ensure all components are correctly configured and synchronized. Otherwise, if the SPMI calibration fails, it will result in the non-serial firmware failing to boot.
TEST=Build pass, non-serial firmware boot ok. BUG=b:341054056
Signed-off-by: Hope Wang hope.wang@mediatek.corp-partner.google.com
Change-Id: I63df384061e4ed2629238f1843decd18d1ad1ac4 Signed-off-by: Hope Wang hope.wang@mediatek.corp-partner.google.com --- M src/soc/mediatek/mt8196/pmif_spmi.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/85799/1
diff --git a/src/soc/mediatek/mt8196/pmif_spmi.c b/src/soc/mediatek/mt8196/pmif_spmi.c index 326c247..e780d2f 100644 --- a/src/soc/mediatek/mt8196/pmif_spmi.c +++ b/src/soc/mediatek/mt8196/pmif_spmi.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only OR MIT */
#include <console/console.h> +#include <delay.h> #include <device/mmio.h> #include <gpio.h> #include <soc/addressmap.h> @@ -285,6 +286,7 @@ { write32(&arb->mtk_pmif->inf_en, PMIF_SPMI_SW_CHAN); write32(&arb->mtk_pmif->arb_en, PMIF_SPMI_SW_CHAN); + udelay(500); printk(BIOS_INFO, "%s done\n", __func__); }