Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email )
The change is no longer submittable: All-Comments-Resolved and Code-Review are unsatisfied now.
Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support ......................................................................
Patch Set 6: Code-Review+1
(10 comments)
Patchset:
PS6: few nits.
File src/soc/mediatek/mt8196/pmif_clk.c:
https://review.coreboot.org/c/coreboot/+/85126/comment/f8f5464e_2de26648?usp... : PS6, Line 117: min_cali_vali align with `BIOS_INFO`.
https://review.coreboot.org/c/coreboot/+/85126/comment/0e5ceeb3_442cd11f?usp... : PS6, Line 149: if (freq_mhz > (target_clk * (1000 - CAL_MIS_RATE) / 1000) : && freq_mhz < (target_clk * (1000 + CAL_MIS_RATE) / 1000)) { : return 0; : } `` if (freq_mhz > (target_clk * (1000 - CAL_MIS_RATE) / 1000) && freq_mhz < (target_clk * (1000 + CAL_MIS_RATE) / 1000)) return 0; ``
File src/soc/mediatek/mt8196/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/85126/comment/708b8360_919d660e?usp... : PS6, Line 132: . remove `.`.
https://review.coreboot.org/c/coreboot/+/85126/comment/c86d85db_75850e65?usp... : PS6, Line 182: . remove `.`.
https://review.coreboot.org/c/coreboot/+/85126/comment/6cef5028_e3b779c3?usp... : PS6, Line 206: . remove `.`.
https://review.coreboot.org/c/coreboot/+/85126/comment/5aa81bca_4d80ead8?usp... : PS6, Line 235: */ one space before `*`.
https://review.coreboot.org/c/coreboot/+/85126/comment/d86e4173_af6f7342?usp... : PS6, Line 239: */ ditto
https://review.coreboot.org/c/coreboot/+/85126/comment/e40343ec_40f41d22?usp... : PS6, Line 249: . remove `.`.
https://review.coreboot.org/c/coreboot/+/85126/comment/3e07892f_d0f69fc9?usp... : PS6, Line 317: channel channels