Change in ...coreboot[master]: mb/dell: Add Dell Optiplex 790

[Christoph Pomaska (Code Review)]

Hello Kyösti Mälkki, Patrick Rudolph, Felix Held, Angel Pons, Johanna Schander, Arthur Heymans, Jonathan Neuschäfer, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/21774

to look at the new patch set (#51).

Change subject: mb/dell: Add Dell Optiplex 790
......................................................................

mb/dell: Add Dell Optiplex 790

This port was generated by autoport and has been tweaked (see below)

There are (at least) three different mainboards:

 - DT:   4 RAM slots, PEG, PCIe x1, PCI, PCIe x16
 - MT:	 4 RAM slots, PEG, PCIe x1, PCI, PCIe x16
 - SFF:  4 RAM slots, PEG, PCIe x16
 - USFF: 2 RAM slots, mPCIe

The variants have different PCI/PCIe configurations and are not
exactly compatible towards each other.

This port has been tested with: USFF

What works:
 - Booting Arch Linux with kernel 5.0.0-arch1-1-ARCH
 - PCIe (Hotplug on PCIe X1 only!)
 - Onboard graphics with libgfxinit (via VGA)
 - Turning on and off (S5)
 - Harddrive activity LED
 - Onboard sound
 - Onboard ethernet
 - SATA (hotplug)
 - IOMMU
 - Suspend/resume (S3)
 - EHCI debug (rear side, bottom port on the block with ethernet)

What does not work:
 - SuperI/O (Chip is a SCH5544-NS)
    - Serial port
    - PS/2
    - Fan control (fans go to full speed)

 - VBT is missing

Further notes:
 - Default IFD settings block reads/writes to some regions. This can be
   bypassed by plugging the SERVICE_MODE jumper. BIOS version A05 does
   not set any protected ranges, so internal flashing is possible (use a
   layout if the SERVICE_MODE jumper is not plugged).
 - Setting the jumper slows down the boot process of coreboot significantly,
   as coreboot waits 900ms for the ME to report an OK DRAM (which doesn't
   happen with the jumper set)
 - The controller that controls the POST code LEDs on the front of the
   case (likely the SuperIO) stays on slow blinking POST 234, corrupt or
   defect BIOS according to [1].
 - The mainboard has one SOIC16 8192KiB and one SOIC8 2048KiB BIOS chip
   that are recognized as one "Opaque flash chip" of 10240K in size.
 - Without the VGA_BIOS_FILE the make process starts behaving weird, so
   I will keep it in until further notice (Is this still true?)

[1] http://www.dell.com/support/article/us/en/04/sln284978/a-reference-guide-to-...

Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f
Signed-off-by: Christoph Pomaska <[e-mail]>
Signed-off-by: Angel Pons <[e-mail]>
---
A src/mainboard/dell/Kconfig
A src/mainboard/dell/Kconfig.name
A src/mainboard/dell/optiplex_790/Kconfig
A src/mainboard/dell/optiplex_790/Kconfig.name
A src/mainboard/dell/optiplex_790/Makefile.inc
A src/mainboard/dell/optiplex_790/acpi/ec.asl
A src/mainboard/dell/optiplex_790/acpi/platform.asl
A src/mainboard/dell/optiplex_790/acpi/superio.asl
A src/mainboard/dell/optiplex_790/acpi_tables.c
A src/mainboard/dell/optiplex_790/board_info.txt
A src/mainboard/dell/optiplex_790/dsdt.asl
A src/mainboard/dell/optiplex_790/gma-mainboard.ads
A src/mainboard/dell/optiplex_790/hda_verb.c
A src/mainboard/dell/optiplex_790/mainboard.c
A src/mainboard/dell/optiplex_790/romstage.c
A src/mainboard/dell/optiplex_790/variants/optiplex_790_mt/devicetree.cb
A src/mainboard/dell/optiplex_790/variants/optiplex_790_mt/gpio.c
A src/mainboard/dell/optiplex_790/variants/optiplex_790_mt/hda_verb.c
A src/mainboard/dell/optiplex_790/variants/optiplex_790_usff/Kconfig
A src/mainboard/dell/optiplex_790/variants/optiplex_790_usff/devicetree.cb
A src/mainboard/dell/optiplex_790/variants/optiplex_790_usff/gpio.c
A src/mainboard/dell/optiplex_790/variants/optiplex_790_usff/hda_verb.c
22 files changed, 1,196 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/21774/51
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/21774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f
Gerrit-Change-Number: 21774
Gerrit-PatchSet: 51
Gerrit-Owner: Christoph Pomaska <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Christoph Pomaska <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Johanna Schander <[e-mail]>
Gerrit-Reviewer: Jonathan Neuschäfer <[e-mail]>
Gerrit-Reviewer: Kyösti Mälkki <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset