Attention is currently required from: Felix Singer, Kyösti Mälkki, Nicholas Chin.
Riku Viitanen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74906?usp=email )
Change subject: mb/hp: Add new port for compaq_8300_elite_usdt ......................................................................
Patch Set 9:
(17 comments)
File src/mainboard/hp/compaq_elite_8300_usdt/Kconfig:
https://review.coreboot.org/c/coreboot/+/74906/comment/91800160_3327cd3f : PS8, Line 5: select BOARD_ROMSIZE_KB_16384 : select HAVE_ACPI_RESUME : select HAVE_ACPI_TABLES : select INTEL_INT15 : select MAINBOARD_HAS_LIBGFXINIT : select NORTHBRIDGE_INTEL_SANDYBRIDGE : select SERIRQ_CONTINUOUS_MODE : select SOUTHBRIDGE_INTEL_C216 : select USE_NATIVE_RAMINIT : select SUPERIO_NUVOTON_NPCD378 : select MAINBOARD_USES_IFD_GBE_REGION : select MAINBOARD_HAS_TPM1 : select MEMORY_MAPPED_TPM : select HAVE_CMOS_DEFAULT : select HAVE_OPTION_TABLE
please order alphabetically […]
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/f44bf76f_152373a8 : PS8, Line 25: string
no need to redefine the type, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/3910e8d0_3fb0f524 : PS8, Line 29: string
no need to redefine the type, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/cfb91db8_e280d14d : PS8, Line 33: string
no need to redefine the type, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/3f43f4ce_84f062bd : PS8, Line 37: int
no need to redefine the type, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/14baf604_54ff766b : PS8, Line 41: int
no need to redefine the type, remove
Done
File src/mainboard/hp/compaq_elite_8300_usdt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74906/comment/a33915fc_b4c30a10 : PS8, Line 4: register "gpu_dp_d_hotplug" = "0"
set to 0 if not configured otherwise, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/d35ef96e_024caf86 : PS8, Line 10: register "gen3_dec" = "0x00000000" :
set to 0 if not configured otherwise, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/1f7321bd_5a1ff792 : PS8, Line 28: device ref mei2 off # Management Engine Interface 2 : end
turned off by default, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/6b29d813_57cf4892 : PS8, Line 30: device ref me_ide_r off # Management Engine IDE-R : end
turned off by default, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/cbb1dcee_359841da : PS8, Line 32: device ref me_kt off # Management Engine KT : end
turned off by default, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/dccff6e8_449287cd : PS8, Line 45: device ref pcie_rp2 off # PCIe Port #2 : end : device ref pcie_rp3 off # PCIe Port #3 : end : device ref pcie_rp4 off # PCIe Port #4 : end : device ref pcie_rp5 off # PCIe Port #5 : end : device ref pcie_rp6 off # PCIe Port #6 : end : device ref pcie_rp7 off # PCIe Port #7 : end : device ref pcie_rp8 off # PCIe Port #8 : end
turned off by default, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/1d16ca5a_2f853ca2 : PS8, Line 158: device ref sata2 off # SATA Controller 2 : end
turned off by default, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/847cfc15_e5adc3b7 : PS8, Line 160: device ref thermal off # Thermal : end
turned off by default, remove
Done
https://review.coreboot.org/c/coreboot/+/74906/comment/36e93e19_d570f8d7 : PS8, Line 167: end
move the end keyword into previous line
Done
File src/mainboard/hp/compaq_elite_8300_usdt/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/74906/comment/608eed25_30724513 : PS8, Line 1: #define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB : #d
Put these defines after the include line
Done
File src/mainboard/hp/compaq_elite_8300_usdt/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/74906/comment/8fd92f50_96433388 : PS8, Line 28:
remove empty line
Done