Attention is currently required from: Jason Glenesk, Nico Huber, Marshall Dawson, Julius Werner, Kyösti Mälkki, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59020 )
Change subject: treewide: Remove unused spinlock functions ......................................................................
Patch Set 2:
(3 comments)
File src/arch/x86/include/arch/smp/spinlock.h:
https://review.coreboot.org/c/coreboot/+/59020/comment/fcb780bc_849d65eb PS2, Line 31: #define barrier() __asm__ __volatile__("" : : : "memory")
In CB:43810 you said it doesn't belong here. […]
Ack
File src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h:
https://review.coreboot.org/c/coreboot/+/59020/comment/77efc16f_aee1b4be PS2, Line 8: #define spin_unlock(lock) do {} while (0)
You can't have <smp/spinlock. […]
Martin, Furquan and Aaron are no longer working on firmware.
Building a zork board should trigger the failure. Here is the failure when deleting this file:
``` In file included from src/drivers/pc80/rtc/post.c:8: src/include/smp/spinlock.h:5:10: fatal error: arch/smp/spinlock.h: No such file or directory 5 | #include <arch/smp/spinlock.h> | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make: *** [Makefile:380: /tmp/coreboot/guybrush/verstage/drivers/pc80/rtc/post.o] Error 1 ```
I suspect that its caused by the `all-` here: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
As for this CL, It's just cleaning up unused functions. This CL + https://review.coreboot.org/c/coreboot/+/59069 leaves this file pretty empty. I'm going to resolve this comment since I'm not planning on untangling this any more. I don't have the time.
https://review.coreboot.org/c/coreboot/+/59020/comment/117a9ebe_186f2b5f PS2, Line 11: #define boot_cpu() 1
no idea. this was copied from the arm spinlock.h.
I removed it here: https://review.coreboot.org/c/coreboot/+/59069
-
Raul Rangel (Code Review)