Change in coreboot[master]: src/mainboard/up/squared: Add Support for iTPM

[Christian Walter (Code Review)]

Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34443 )

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

src/mainboard/up/squared: Add Support for iTPM

Add Support for the integrated TPM in KConfig and update Device Tree.

Change-Id: I3a51545c493674aeed9aef72db24f77315d033ce
Signed-off-by: Christian Walter 
---
M src/mainboard/up/squared/Kconfig
M src/mainboard/up/squared/devicetree.cb
2 files changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/34443/1

diff --git a/src/mainboard/up/squared/Kconfig b/src/mainboard/up/squared/Kconfig
index b9f5b27..59bd2ce 100644
--- a/src/mainboard/up/squared/Kconfig
+++ b/src/mainboard/up/squared/Kconfig
@@ -13,6 +13,7 @@
    select BOARD_ROMSIZE_KB_16384
    select ONBOARD_VGA_IS_PRIMARY
    select MAINBOARD_HAS_LIBGFXINIT
+	select MAINBOARD_HAS_CRB_TPM

config VBOOT
    select VBOOT_NO_BOARD_SUPPORT
diff --git a/src/mainboard/up/squared/devicetree.cb b/src/mainboard/up/squared/devicetree.cb
index 2a49db6..66be75c 100644
--- a/src/mainboard/up/squared/devicetree.cb
+++ b/src/mainboard/up/squared/devicetree.cb
@@ -49,4 +49,7 @@
    	device pci 1f.0 on end	# - LPC
    	device pci 1f.1 on end	# - SMBUS
    end
+	chip drivers/crb
+		device mmio 0xfed40000 on end
+	end
 end

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34443 )

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34443/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34443/5//COMMIT_MSG@9 
PS5, Line 9: Support
support

https://review.coreboot.org/c/coreboot/+/34443/5//COMMIT_MSG@9 
PS5, Line 9: Device Tree
device tree

https://review.coreboot.org/c/coreboot/+/34443/5//COMMIT_MSG@9 
PS5, Line 9: KConfig
Kconfig

[Christian Walter (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34443

to look at the new patch set (#6).

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

src/mainboard/up/squared: Add Support for iTPM

Add Support for the integrated TPM in KConfig and update Device Tree.

Change-Id: I3a51545c493674aeed9aef72db24f77315d033ce
Signed-off-by: Christian Walter 
---
M src/mainboard/up/squared/Kconfig
M src/mainboard/up/squared/devicetree.cb
2 files changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/34443/6

[Christian Walter (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34443

to look at the new patch set (#8).

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

src/mainboard/up/squared: Add Support for iTPM

Add support for the integrated TPM in Kconfig and update device tree.

Change-Id: I3a51545c493674aeed9aef72db24f77315d033ce
Signed-off-by: Christian Walter 
---
M src/mainboard/up/squared/Kconfig
M src/mainboard/up/squared/devicetree.cb
2 files changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/34443/8

[Christian Walter (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34443

to look at the new patch set (#9).

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

src/mainboard/up/squared: Add Support for iTPM

Add Support for the integrated TPM in KConfig and update Device Tree.

Change-Id: I3a51545c493674aeed9aef72db24f77315d033ce
Signed-off-by: Christian Walter 
---
M src/mainboard/up/squared/Kconfig
M src/mainboard/up/squared/devicetree.cb
2 files changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/34443/9

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34443 )

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

Patch Set 9:

The commit message fixes were reverted in the last upload.

[Christian Walter (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34443

to look at the new patch set (#12).

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

src/mainboard/up/squared: Add Support for iTPM

Add support for the integrated TPM in Kconfig and update device tree.

Change-Id: I3a51545c493674aeed9aef72db24f77315d033ce
Signed-off-by: Christian Walter 
---
M src/mainboard/up/squared/Kconfig
M src/mainboard/up/squared/devicetree.cb
2 files changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/34443/12

[Christian Walter (Code Review)]

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34443 )

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

Patch Set 11:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34443/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34443/5//COMMIT_MSG@9 
PS5, Line 9: Support
> support

Done

https://review.coreboot.org/c/coreboot/+/34443/5//COMMIT_MSG@9 
PS5, Line 9: Device Tree
> device tree

Done

https://review.coreboot.org/c/coreboot/+/34443/5//COMMIT_MSG@9 
PS5, Line 9: KConfig
> Kconfig

Done

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34443 )

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

Patch Set 12: Code-Review+2

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34443 )

Change subject: src/mainboard/up/squared: Add Support for iTPM
......................................................................

src/mainboard/up/squared: Add Support for iTPM

Add support for the integrated TPM in Kconfig and update device tree.

Change-Id: I3a51545c493674aeed9aef72db24f77315d033ce
Signed-off-by: Christian Walter 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34443
Tested-by: build bot (Jenkins) 
Reviewed-by: Philipp Deppenwiese 
---
M src/mainboard/up/squared/Kconfig
M src/mainboard/up/squared/devicetree.cb
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved

diff --git a/src/mainboard/up/squared/Kconfig b/src/mainboard/up/squared/Kconfig
index b9f5b27..5db76fd 100644
--- a/src/mainboard/up/squared/Kconfig
+++ b/src/mainboard/up/squared/Kconfig
@@ -13,6 +13,8 @@
    select BOARD_ROMSIZE_KB_16384
    select ONBOARD_VGA_IS_PRIMARY
    select MAINBOARD_HAS_LIBGFXINIT
+	select MAINBOARD_HAS_CRB_TPM
+	select HAVE_INTEL_PTT

config VBOOT
    select VBOOT_NO_BOARD_SUPPORT
diff --git a/src/mainboard/up/squared/devicetree.cb b/src/mainboard/up/squared/devicetree.cb
index 2a49db6..66be75c 100644
--- a/src/mainboard/up/squared/devicetree.cb
+++ b/src/mainboard/up/squared/devicetree.cb
@@ -49,4 +49,7 @@
    	device pci 1f.0 on end	# - LPC
    	device pci 1f.1 on end	# - SMBUS
    end
+	chip drivers/crb
+		device mmio 0xfed40000 on end
+	end
 end