Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68489 )
Change subject: soc/mediatek/mt8188: Update mtcmos settings for display and audio ......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/common/mtcmos.c:
https://review.coreboot.org/c/coreboot/+/68489/comment/c24e1735_edcebe59 PS5, Line 17: { Move to next line
``` { /* do nothing */ } ```
https://review.coreboot.org/c/coreboot/+/68489/comment/e1f125e1_ba2f0c52 PS5, Line 24: mtcmos_set_scpd_ext_buck_iso(pd); If this is controlled by `SCPD_EXT_BUCK_ISO`, why do we need the weak function? Can't we write
``` if (pd->caps & SCPD_EXT_BUCK_ISO) clrbits32(&mtk_spm->ext_buck_iso, pd->ext_buck_iso_bits); ```
directly here?