Attention is currently required from: Jakub Czapiga, Yu-Ping Wu.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80621?usp=email )
Change subject: tests/lib/ux_locales-test: Simplify macros
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File tests/lib/ux_locales-test.c:
https://review.coreboot.org/c/coreboot/+/80621/comment/1910e26d_2ceea8b5 :
PS2, Line 210: NULL
I think the comment for `UX_LOCALES_GET_TEXT_TEST` is already pretty clear that `NULL` means "text n […]
I don't have strong opinions.
I just tried to improve readability without digging into the MACRO's implementation. Since the MACRO comments are clear enough, I'm okay with the current version.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80621?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3199e2a061550282fb08122943994c835845543
Gerrit-Change-Number: 80621
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 20 Feb 2024 07:52:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment