Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68700 )
Change subject: soc/intel/tigerlake: Clean up includes ......................................................................
soc/intel/tigerlake: Clean up includes
Change-Id: I9c75e900d05d16de830c750f074df84bb17f64dc Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/68700 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak inforichland@gmail.com --- M src/soc/intel/tigerlake/bootblock/bootblock.c M src/soc/intel/tigerlake/dptf.c M src/soc/intel/tigerlake/elog.c M src/soc/intel/tigerlake/fsp_params.c M src/soc/intel/tigerlake/lockdown.c M src/soc/intel/tigerlake/me.c M src/soc/intel/tigerlake/p2sb.c M src/soc/intel/tigerlake/pcie_rp.c M src/soc/intel/tigerlake/retimer.c M src/soc/intel/tigerlake/romstage/systemagent.c M src/soc/intel/tigerlake/spi.c M src/soc/intel/tigerlake/xhci.c 12 files changed, 31 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/bootblock/bootblock.c b/src/soc/intel/tigerlake/bootblock/bootblock.c index b8086a4..5ef9662 100644 --- a/src/soc/intel/tigerlake/bootblock/bootblock.c +++ b/src/soc/intel/tigerlake/bootblock/bootblock.c @@ -1,11 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> +#include <cpu/cpu.h> #include <intelblocks/fast_spi.h> #include <intelblocks/systemagent.h> #include <intelblocks/tco.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> +#include <stdint.h>
asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { diff --git a/src/soc/intel/tigerlake/dptf.c b/src/soc/intel/tigerlake/dptf.c index 2f0427e..2f4cf5f 100644 --- a/src/soc/intel/tigerlake/dptf.c +++ b/src/soc/intel/tigerlake/dptf.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <drivers/intel/dptf/dptf.h> +#include <stdbool.h>
static const struct dptf_platform_info tgl_dptf_platform_info = { .use_eisa_hids = false, diff --git a/src/soc/intel/tigerlake/elog.c b/src/soc/intel/tigerlake/elog.c index 301c88a..29f1712 100644 --- a/src/soc/intel/tigerlake/elog.c +++ b/src/soc/intel/tigerlake/elog.c @@ -1,8 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <acpi/acpi.h> #include <bootstate.h> +#include <commonlib/bsd/helpers.h> #include <console/console.h> +#include <device/pci_def.h> #include <device/pci_ops.h> +#include <device/pci_type.h> #include <elog.h> #include <intelblocks/pmclib.h> #include <intelblocks/xhci.h> diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c index ef75c56..d7c60be 100644 --- a/src/soc/intel/tigerlake/fsp_params.c +++ b/src/soc/intel/tigerlake/fsp_params.c @@ -3,7 +3,6 @@ #include <assert.h> #include <console/console.h> #include <device/device.h> -#include <arch/pci_io_cfg.h> #include <cpu/intel/cpu_ids.h> #include <device/pci_ops.h> #include <device/pci.h> diff --git a/src/soc/intel/tigerlake/lockdown.c b/src/soc/intel/tigerlake/lockdown.c index 1e04dc3..2f7cceb 100644 --- a/src/soc/intel/tigerlake/lockdown.c +++ b/src/soc/intel/tigerlake/lockdown.c @@ -10,6 +10,7 @@ #include <intelblocks/cfg.h> #include <intelpch/lockdown.h> #include <soc/pm.h> +#include <stdint.h>
static void pmc_lock_pmsync(void) { diff --git a/src/soc/intel/tigerlake/me.c b/src/soc/intel/tigerlake/me.c index ea94902..560464f 100644 --- a/src/soc/intel/tigerlake/me.c +++ b/src/soc/intel/tigerlake/me.c @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <intelblocks/cse.h> #include <console/console.h> +#include <intelblocks/cse.h> #include <soc/me.h> -#include <stdint.h> +#include <types.h>
/* Host Firmware Status Register 2 */ union me_hfsts2 { diff --git a/src/soc/intel/tigerlake/p2sb.c b/src/soc/intel/tigerlake/p2sb.c index fc8323a..1a0f23f 100644 --- a/src/soc/intel/tigerlake/p2sb.c +++ b/src/soc/intel/tigerlake/p2sb.c @@ -8,6 +8,7 @@
#include <console/console.h> #include <intelblocks/p2sb.h> +#include <types.h>
void p2sb_soc_get_sb_mask(uint32_t *ep_mask, size_t count) { diff --git a/src/soc/intel/tigerlake/pcie_rp.c b/src/soc/intel/tigerlake/pcie_rp.c index 57a5cf2..01bca17 100644 --- a/src/soc/intel/tigerlake/pcie_rp.c +++ b/src/soc/intel/tigerlake/pcie_rp.c @@ -1,8 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/device.h> +#include <device/pci_def.h> #include <intelblocks/pcie_rp.h> #include <soc/pci_devs.h> +#include <stdbool.h>
#define CPU_CPIE_VW_IDX_BASE 24
diff --git a/src/soc/intel/tigerlake/retimer.c b/src/soc/intel/tigerlake/retimer.c index 09bf112..32cb828 100644 --- a/src/soc/intel/tigerlake/retimer.c +++ b/src/soc/intel/tigerlake/retimer.c @@ -4,6 +4,7 @@ #include <device/device.h> #include <drivers/intel/usb4/retimer/retimer.h> #include <intelblocks/tcss.h> +#include <stdint.h>
int retimer_get_index_for_typec(uint8_t typec_port) { diff --git a/src/soc/intel/tigerlake/romstage/systemagent.c b/src/soc/intel/tigerlake/romstage/systemagent.c index bedc192..2393e6a 100644 --- a/src/soc/intel/tigerlake/romstage/systemagent.c +++ b/src/soc/intel/tigerlake/romstage/systemagent.c @@ -6,6 +6,7 @@ * Chapter number: 3 */
+#include <commonlib/bsd/helpers.h> #include <intelblocks/systemagent.h> #include <soc/iomap.h> #include <soc/romstage.h> diff --git a/src/soc/intel/tigerlake/spi.c b/src/soc/intel/tigerlake/spi.c index d68b146..47b3b33 100644 --- a/src/soc/intel/tigerlake/spi.c +++ b/src/soc/intel/tigerlake/spi.c @@ -6,9 +6,10 @@ * Chapter number: 7 */
-#include <intelblocks/spi.h> #include <intelblocks/fast_spi.h> +#include <intelblocks/spi.h> #include <soc/pci_devs.h> +#include <stdint.h>
#define PSF_SPI_DESTINATION_ID_H 0x23b0 #define PSF_SPI_DESTINATION_ID 0x23a8 diff --git a/src/soc/intel/tigerlake/xhci.c b/src/soc/intel/tigerlake/xhci.c index 6f095fa..af201aa 100644 --- a/src/soc/intel/tigerlake/xhci.c +++ b/src/soc/intel/tigerlake/xhci.c @@ -3,6 +3,7 @@ #include <device/pci_type.h> #include <intelblocks/xhci.h> #include <soc/pci_devs.h> +#include <stddef.h>
#define PCH_XHCI_USB2_PORT_STATUS_REG 0x480 #define PCH_XHCI_USB3_PORT_STATUS_REG 0x520
-
Martin Roth (Code Review)