Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30118 )
Change subject: arch/x86/boot: Jump to payload in protected mode ......................................................................
Patch Set 26:
(9 comments)
https://review.coreboot.org/c/coreboot/+/30118/25//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/30118/25//COMMIT_MSG@10 PS25, Line 10: arbitraty
arbitrary
Done
https://review.coreboot.org/c/coreboot/+/30118/25//COMMIT_MSG@12 PS25, Line 12: qemu
- QEMU […]
Done
https://review.coreboot.org/c/coreboot/+/30118/25//COMMIT_MSG@12 PS25, Line 12: SeaBios
SeaBIOS
Done
https://review.coreboot.org/c/coreboot/+/30118/23/src/arch/x86/boot.c File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/30118/23/src/arch/x86/boot.c@34 PS23, Line 34: NV_RAMSTAGE : protected_mode_call
I think it is worth explaining why payloads are run in protected_mode here.
Done
https://review.coreboot.org/c/coreboot/+/30118/25/src/arch/x86/c_exit.S File src/arch/x86/c_exit.S:
https://review.coreboot.org/c/coreboot/+/30118/25/src/arch/x86/c_exit.S@22 PS25, Line 22: longmode
long mode
Done
https://review.coreboot.org/c/coreboot/+/30118/25/src/arch/x86/c_exit.S@39 PS25, Line 39: instuction
instruction
Done
https://review.coreboot.org/c/coreboot/+/30118/25/src/arch/x86/c_exit.S@68 PS25, Line 68: /* Ensure cache is clean. */
Remove the dot?
Done
https://review.coreboot.org/c/coreboot/+/30118/25/src/include/program_loadin... File src/include/program_loading.h:
https://review.coreboot.org/c/coreboot/+/30118/25/src/include/program_loadin... PS25, Line 193: /* Jump to function in protected mode.
Add blank comment line at start?
Done
https://review.coreboot.org/c/coreboot/+/30118/25/src/include/program_loadin... PS25, Line 198: */
Add space in front?
Done
-
Patrick Rudolph (Code Review)