HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43968 )
Change subject: src/drivers: Add missing <{stddef,stdint}.h> ......................................................................
src/drivers: Add missing <{stddef,stdint}.h>
Change-Id: I4f7699c18c82c39af3c9741105150bb6d9599781 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/state_machine.c M src/drivers/aspeed/common/aspeed_coreboot.h M src/drivers/crb/tis.c M src/drivers/crb/tpm.c M src/drivers/crb/tpm.h M src/drivers/generic/cbfs-serial/cbfs-serial.c M src/drivers/gfx/generic/generic.c M src/drivers/i2c/designware/dw_i2c.c M src/drivers/i2c/designware/dw_i2c.h M src/drivers/i2c/tpm/tis.c M src/drivers/i2c/tpm/tpm.h M src/drivers/intel/fsp1_1/fsp_relocate.c M src/drivers/intel/fsp1_1/mma_core.c M src/drivers/intel/fsp1_1/vbt.c M src/drivers/intel/fsp2_0/debug.c M src/drivers/intel/fsp2_0/hob_display.c M src/drivers/intel/fsp2_0/include/fsp/debug.h M src/drivers/intel/fsp2_0/mma_core.c M src/drivers/intel/fsp2_0/upd_display.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/gma/vbt.c M src/drivers/pc80/tpm/tis.c M src/drivers/secunet/dmi/smbios.c M src/drivers/spi/bitbang.c M src/drivers/spi/spi_flash_internal.h M src/drivers/spi/spi_sdcard.c M src/drivers/spi/sst.c M src/drivers/spi/tpm/tis.c M src/drivers/spi/tpm/tpm.c 29 files changed, 53 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/43968/1
diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c index 606a66f..01431b7 100644 --- a/src/drivers/amd/agesa/state_machine.c +++ b/src/drivers/amd/agesa/state_machine.c @@ -5,6 +5,7 @@ #include <acpi/acpi.h> #include <bootstate.h> #include <cbfs.h> +#include <stddef.h> #include <timestamp.h>
#include <northbridge/amd/agesa/state_machine.h> diff --git a/src/drivers/aspeed/common/aspeed_coreboot.h b/src/drivers/aspeed/common/aspeed_coreboot.h index 3f740b2..57e3ec2 100644 --- a/src/drivers/aspeed/common/aspeed_coreboot.h +++ b/src/drivers/aspeed/common/aspeed_coreboot.h @@ -4,6 +4,7 @@ #define _ASPEED_COREBOOT_
#include <delay.h> +#include <stddef.h> #include <stdlib.h> #include <stdint.h> #include <string.h> diff --git a/src/drivers/crb/tis.c b/src/drivers/crb/tis.c index 9d12690..9359ac7 100644 --- a/src/drivers/crb/tis.c +++ b/src/drivers/crb/tis.c @@ -5,6 +5,8 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <drivers/intel/ptt/ptt.h> +#include <stddef.h> +#include <stdint.h>
#include "tpm.h" #include "chip.h" diff --git a/src/drivers/crb/tpm.c b/src/drivers/crb/tpm.c index 6436725..7c7f8e0 100644 --- a/src/drivers/crb/tpm.c +++ b/src/drivers/crb/tpm.c @@ -19,6 +19,8 @@ #include <string.h> #include <soc/pci_devs.h> #include <device/pci_ops.h> +#include <stddef.h> +#include <stdint.h>
#include "tpm.h"
diff --git a/src/drivers/crb/tpm.h b/src/drivers/crb/tpm.h index 449d02f..9c0effd 100644 --- a/src/drivers/crb/tpm.h +++ b/src/drivers/crb/tpm.h @@ -3,6 +3,10 @@
/* CRB driver */ /* address of locality 0 (CRB) */ + +#include <stddef.h> +#include <stdint.h> + #define TPM_CRB_BASE_ADDRESS CONFIG_CRB_TPM_BASE_ADDRESS
#define CRB_REG(LOCTY, REG) \ diff --git a/src/drivers/generic/cbfs-serial/cbfs-serial.c b/src/drivers/generic/cbfs-serial/cbfs-serial.c index 2e3e37d..78ab0d5 100644 --- a/src/drivers/generic/cbfs-serial/cbfs-serial.c +++ b/src/drivers/generic/cbfs-serial/cbfs-serial.c @@ -3,6 +3,7 @@ #include <cbfs.h> #include <device/device.h> #include <smbios.h> +#include <stddef.h> #include <string.h>
diff --git a/src/drivers/gfx/generic/generic.c b/src/drivers/gfx/generic/generic.c index 546f30b..621482b 100644 --- a/src/drivers/gfx/generic/generic.c +++ b/src/drivers/gfx/generic/generic.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> +#include <stddef.h>
#include "chip.h"
diff --git a/src/drivers/i2c/designware/dw_i2c.c b/src/drivers/i2c/designware/dw_i2c.c index 00865e3..f690c9c 100644 --- a/src/drivers/i2c/designware/dw_i2c.c +++ b/src/drivers/i2c/designware/dw_i2c.c @@ -6,8 +6,11 @@ #include <device/device.h> #include <device/i2c_bus.h> #include <device/i2c_simple.h> +#include <stddef.h> +#include <stdint.h> #include <string.h> #include <timer.h> + #include "dw_i2c.h"
/* Use a ~10ms timeout for various operations */ diff --git a/src/drivers/i2c/designware/dw_i2c.h b/src/drivers/i2c/designware/dw_i2c.h index 45f305e..a69173c 100644 --- a/src/drivers/i2c/designware/dw_i2c.h +++ b/src/drivers/i2c/designware/dw_i2c.h @@ -5,6 +5,7 @@
#include <device/device.h> #include <device/i2c.h> +#include <stddef.h> #include <stdint.h>
#if CONFIG(DRIVERS_I2C_DESIGNWARE_DEBUG) diff --git a/src/drivers/i2c/tpm/tis.c b/src/drivers/i2c/tpm/tis.c index 217d8c6..33071ab 100644 --- a/src/drivers/i2c/tpm/tis.c +++ b/src/drivers/i2c/tpm/tis.c @@ -10,6 +10,7 @@ #include <endian.h> #include <lib.h> #include <security/tpm/tis.h> +#include <stddef.h>
#include "tpm.h"
diff --git a/src/drivers/i2c/tpm/tpm.h b/src/drivers/i2c/tpm/tpm.h index eb4fef1..56af45e 100644 --- a/src/drivers/i2c/tpm/tpm.h +++ b/src/drivers/i2c/tpm/tpm.h @@ -12,6 +12,7 @@ #ifndef __DRIVERS_TPM_SLB9635_I2C_TPM_H__ #define __DRIVERS_TPM_SLB9635_I2C_TPM_H__
+#include <stddef.h> #include <stdint.h>
enum tpm_timeout { diff --git a/src/drivers/intel/fsp1_1/fsp_relocate.c b/src/drivers/intel/fsp1_1/fsp_relocate.c index d078f59..11a2655 100644 --- a/src/drivers/intel/fsp1_1/fsp_relocate.c +++ b/src/drivers/intel/fsp1_1/fsp_relocate.c @@ -4,6 +4,8 @@ #include <cbmem.h> #include <commonlib/fsp.h> #include <fsp/util.h> +#include <stddef.h> +#include <stdint.h>
int fsp_relocate(struct prog *fsp_relocd, const struct region_device *fsp_src) { diff --git a/src/drivers/intel/fsp1_1/mma_core.c b/src/drivers/intel/fsp1_1/mma_core.c index 6e50373..9f41674 100644 --- a/src/drivers/intel/fsp1_1/mma_core.c +++ b/src/drivers/intel/fsp1_1/mma_core.c @@ -4,6 +4,7 @@ #include <fsp/util.h> #include <fsp/romstage.h> #include <fsp/soc_binding.h> +#include <stddef.h>
#define FSP_MMA_RESULTS_GUID { 0x8f4e928, 0xf5f, 0x46d4, \ { 0x84, 0x10, 0x47, 0x9f, 0xda, 0x27, 0x9d, 0xb6 } } diff --git a/src/drivers/intel/fsp1_1/vbt.c b/src/drivers/intel/fsp1_1/vbt.c index 88f14ee..52cba1a 100644 --- a/src/drivers/intel/fsp1_1/vbt.c +++ b/src/drivers/intel/fsp1_1/vbt.c @@ -6,6 +6,8 @@ #include <fsp/ramstage.h> #include <fsp/util.h> #include <lib.h> +#include <stddef.h> +#include <stdint.h>
/* Locate VBT and pass it to FSP GOP */ void load_vbt(uint8_t s3_resume, SILICON_INIT_UPD *params) diff --git a/src/drivers/intel/fsp2_0/debug.c b/src/drivers/intel/fsp2_0/debug.c index 3d66587..731d344 100644 --- a/src/drivers/intel/fsp2_0/debug.c +++ b/src/drivers/intel/fsp2_0/debug.c @@ -4,6 +4,8 @@ #include <console/streams.h> #include <cpu/x86/mtrr.h> #include <fsp/util.h> +#include <stddef.h> +#include <stdint.h>
asmlinkage size_t fsp_write_line(uint8_t *buffer, size_t number_of_bytes) { diff --git a/src/drivers/intel/fsp2_0/hob_display.c b/src/drivers/intel/fsp2_0/hob_display.c index f21ebfe..e955e2e 100644 --- a/src/drivers/intel/fsp2_0/hob_display.c +++ b/src/drivers/intel/fsp2_0/hob_display.c @@ -2,6 +2,8 @@
#include <console/console.h> #include <fsp/util.h> +#include <stddef.h> +#include <stdint.h>
struct hob_type_name { uint16_t type; diff --git a/src/drivers/intel/fsp2_0/include/fsp/debug.h b/src/drivers/intel/fsp2_0/include/fsp/debug.h index e3d1918..9408d37 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/debug.h +++ b/src/drivers/intel/fsp2_0/include/fsp/debug.h @@ -4,6 +4,8 @@ #define _FSP2_0_DEBUG_H_
#include <fsp/util.h> +#include <stddef.h> +#include <stdint.h>
/* FSP debug API */ void fsp_debug_before_memory_init(fsp_memory_init_fn memory_init, diff --git a/src/drivers/intel/fsp2_0/mma_core.c b/src/drivers/intel/fsp2_0/mma_core.c index c19b299..94b9a08 100644 --- a/src/drivers/intel/fsp2_0/mma_core.c +++ b/src/drivers/intel/fsp2_0/mma_core.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <fsp/util.h> #include <fsp/soc_binding.h> +#include <stddef.h> +#include <stdint.h>
static const uint8_t mma_results_uuid[16] = { 0x28, 0xe9, 0xf4, 0x08, 0x5f, 0x0f, 0xd4, 0x46, diff --git a/src/drivers/intel/fsp2_0/upd_display.c b/src/drivers/intel/fsp2_0/upd_display.c index 63d6e60..032bb2c 100644 --- a/src/drivers/intel/fsp2_0/upd_display.c +++ b/src/drivers/intel/fsp2_0/upd_display.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <fsp/util.h> #include <lib.h> +#include <stddef.h> +#include <stdint.h>
void fsp_display_upd_value(const char *name, size_t size, uint64_t old, uint64_t new) diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 4a89bb9..fd78255 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <string.h> #include "i915.h" +#include <stddef.h>
void drivers_intel_gma_displays_ssdt_generate(const struct i915_gpu_controller_info *conf) diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index b42c52d..dd85592 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -5,6 +5,8 @@ #include <string.h> #include <device/pci.h> #include <drivers/intel/gma/opregion.h> +#include <stddef.h> +#include <stdint.h>
#include "i915.h" #include "intel_bios.h" diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index 27d238c..fe93796 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -21,6 +21,9 @@ #include <console/console.h> #include <security/tpm/tis.h> #include <device/pnp.h> +#include <stddef.h> +#include <stdint.h> + #include "chip.h"
#define PREFIX "lpc_tpm: " diff --git a/src/drivers/secunet/dmi/smbios.c b/src/drivers/secunet/dmi/smbios.c index f407b51..265b5ad 100644 --- a/src/drivers/secunet/dmi/smbios.c +++ b/src/drivers/secunet/dmi/smbios.c @@ -9,6 +9,7 @@ #include <device/device.h> #include <device/i2c_bus.h> #include <smbios.h> +#include <stddef.h>
#include "eeprom.h"
diff --git a/src/drivers/spi/bitbang.c b/src/drivers/spi/bitbang.c index 168ec64..54a91c5 100644 --- a/src/drivers/spi/bitbang.c +++ b/src/drivers/spi/bitbang.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <delay.h> #include <spi_bitbang.h> +#include <stddef.h> +#include <stdint.h>
/* Set to 1 to dump all SPI transfers to the UART. */ #define TRACE 0 diff --git a/src/drivers/spi/spi_flash_internal.h b/src/drivers/spi/spi_flash_internal.h index b4d39b3..fa99723 100644 --- a/src/drivers/spi/spi_flash_internal.h +++ b/src/drivers/spi/spi_flash_internal.h @@ -7,6 +7,9 @@ #ifndef SPI_FLASH_INTERNAL_H #define SPI_FLASH_INTERNAL_H
+#include <stddef.h> +#include <stdint.h> + /* Common commands */ #define CMD_READ_ID 0x9f
diff --git a/src/drivers/spi/spi_sdcard.c b/src/drivers/spi/spi_sdcard.c index 5d0a71b..55be5dd 100644 --- a/src/drivers/spi/spi_sdcard.c +++ b/src/drivers/spi/spi_sdcard.c @@ -1,4 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + #include <stdint.h> #include <string.h> #include <spi-generic.h> @@ -6,6 +7,7 @@ #include <crc_byte.h> #include <commonlib/helpers.h> #include <console/console.h> +#include <stddef.h>
//#define SPI_SDCARD_DEBUG
diff --git a/src/drivers/spi/sst.c b/src/drivers/spi/sst.c index 887380f..d721668 100644 --- a/src/drivers/spi/sst.c +++ b/src/drivers/spi/sst.c @@ -8,6 +8,8 @@ #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> +#include <stddef.h> +#include <stdint.h>
#include "spi_flash_internal.h"
diff --git a/src/drivers/spi/tpm/tis.c b/src/drivers/spi/tpm/tis.c index 6849ea7..db74067 100644 --- a/src/drivers/spi/tpm/tis.c +++ b/src/drivers/spi/tpm/tis.c @@ -2,6 +2,8 @@
#include <console/console.h> #include <security/tpm/tis.h> +#include <stddef.h> +#include <stdint.h>
#include "tpm.h"
diff --git a/src/drivers/spi/tpm/tpm.c b/src/drivers/spi/tpm/tpm.c index 4263dce..5bbb8a6 100644 --- a/src/drivers/spi/tpm/tpm.c +++ b/src/drivers/spi/tpm/tpm.c @@ -19,6 +19,8 @@ #include <string.h> #include <timer.h> #include <security/tpm/tis.h> +#include <stddef.h> +#include <stdint.h>
#include "tpm.h"
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43968 )
Change subject: src/drivers: Add missing <{stddef,stdint}.h> ......................................................................
Patch Set 2:
(47 comments)
I've added comments to highlight why stdint or/and stddef are needed. this to make the review easier. Thx
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/amd/agesa/state... File src/drivers/amd/agesa/state_machine.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/amd/agesa/state... PS2, Line 32: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/aspeed_coreboot.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/aspeed/common/a... PS2, Line 49: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tis.c File src/drivers/crb/tis.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tis.c@17 PS2, Line 17: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tis.c@85 PS2, Line 85: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.h File src/drivers/crb/tpm.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.h@60 PS2, Line 60: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.h@68 PS2, Line 68: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.c File src/drivers/crb/tpm.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.c@28 PS2, Line 28: uint32_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.c@200 PS2, Line 200: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/generic/cbfs-se... File src/drivers/generic/cbfs-serial/cbfs-serial.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/generic/cbfs-se... PS2, Line 22: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/gfx/generic/gen... File src/drivers/gfx/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/gfx/generic/gen... PS2, Line 105: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... File src/drivers/i2c/designware/dw_i2c.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... PS2, Line 124: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... PS2, Line 40: uint32_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... PS2, Line 230: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/tpm/tis.c File src/drivers/i2c/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/tpm/tis.c@5... PS2, Line 59: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/tpm/tpm.h File src/drivers/i2c/tpm/tpm.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/tpm/tpm.h@4... PS2, Line 47: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/fs... File src/drivers/intel/fsp1_1/fsp_relocate.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/fs... PS2, Line 14: ssize_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/fs... PS2, Line 36: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/mm... File src/drivers/intel/fsp1_1/mma_core.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/mm... PS2, Line 12: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/vb... File src/drivers/intel/fsp1_1/vbt.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/vb... PS2, Line 13: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/vb... PS2, Line 16: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/de... File src/drivers/intel/fsp2_0/debug.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/de... PS2, Line 10: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/de... PS2, Line 10: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/ho... File src/drivers/intel/fsp2_0/hob_display.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/ho... PS2, Line 9: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/ho... PS2, Line 121: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/in... File src/drivers/intel/fsp2_0/include/fsp/debug.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/in... PS2, Line 14: uint32_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/in... PS2, Line 44: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/mm... File src/drivers/intel/fsp2_0/mma_core.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/mm... PS2, Line 9: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/mm... PS2, Line 13: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/up... File src/drivers/intel/fsp2_0/upd_display.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/up... PS2, Line 9: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/up... PS2, Line 10: uint64_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/acpi.... File src/drivers/intel/gma/acpi.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/acpi.... PS2, Line 12: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/vbt.c File src/drivers/intel/gma/vbt.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/vbt.c... PS2, Line 14: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/vbt.c... PS2, Line 18: u8 stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/pc80/tpm/tis.c File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/pc80/tpm/tis.c@... PS2, Line 100: u16 stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/pc80/tpm/tis.c@... PS2, Line 534: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/secunet/dmi/smb... File src/drivers/secunet/dmi/smbios.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/secunet/dmi/smb... PS2, Line 30: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/bitbang.c File src/drivers/spi/bitbang.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/bitbang.c@3... PS2, Line 32: size_t stdded
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/bitbang.c@4... PS2, Line 45: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_flash_i... File src/drivers/spi/spi_flash_internal.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_flash_i... PS2, Line 31: u8 stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_flash_i... PS2, Line 38: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_sdcard.... File src/drivers/spi/spi_sdcard.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_sdcard.... PS2, Line 364: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/sst.c File src/drivers/spi/sst.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/sst.c@146 PS2, Line 146: u32 stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/sst.c@149 PS2, Line 149: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tis.c File src/drivers/spi/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tis.c@1... PS2, Line 13: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tis.c@8... PS2, Line 81: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tpm.c File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tpm.c@1... PS2, Line 103: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tpm.c@1... PS2, Line 106: uint8_t stdint
Hello build bot (Jenkins), Lee Leahy, Christian Walter, Huang Jin, Arthur Heymans, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43968
to look at the new patch set (#3).
Change subject: src/drivers: Add missing <{stddef,stdint}.h> covered by <types.h> ......................................................................
src/drivers: Add missing <{stddef,stdint}.h> covered by <types.h>
Change-Id: I4f7699c18c82c39af3c9741105150bb6d9599781 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/state_machine.c M src/drivers/aspeed/common/aspeed_coreboot.h M src/drivers/crb/tis.c M src/drivers/crb/tpm.c M src/drivers/crb/tpm.h M src/drivers/generic/cbfs-serial/cbfs-serial.c M src/drivers/gfx/generic/generic.c M src/drivers/i2c/designware/dw_i2c.c M src/drivers/i2c/designware/dw_i2c.h M src/drivers/i2c/tpm/tis.c M src/drivers/i2c/tpm/tpm.h M src/drivers/intel/fsp1_1/fsp_relocate.c M src/drivers/intel/fsp1_1/mma_core.c M src/drivers/intel/fsp1_1/vbt.c M src/drivers/intel/fsp2_0/debug.c M src/drivers/intel/fsp2_0/hob_display.c M src/drivers/intel/fsp2_0/include/fsp/debug.h M src/drivers/intel/fsp2_0/mma_core.c M src/drivers/intel/fsp2_0/upd_display.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/gma/vbt.c M src/drivers/pc80/tpm/tis.c M src/drivers/secunet/dmi/smbios.c M src/drivers/smmstore/smi.c M src/drivers/spi/bitbang.c M src/drivers/spi/spi_flash_internal.h M src/drivers/spi/spi_sdcard.c M src/drivers/spi/sst.c M src/drivers/spi/tpm/tis.c M src/drivers/spi/tpm/tpm.c M src/drivers/uart/oxpcie_early.c 31 files changed, 37 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/43968/3
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43968 )
Change subject: src/drivers: Add missing <{stddef,stdint}.h> covered by <types.h> ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)