Attention is currently required from: Moritz Fischer. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51128 )
Change subject: soc/rockchip/rk3399/sdram: Move pwrup_srefresh_exit to array ......................................................................
Patch Set 1:
(1 comment)
File src/soc/rockchip/rk3399/sdram.c:
https://review.coreboot.org/c/coreboot/+/51128/comment/eca92a20_5473cdf3 PS1, Line 95: u32 pwrup_srefresh_exit[MAX_DRAM_CHANNELS]; Let's try to avoid using globals to pass values between functions where possible. Looks like your goal is just to pass this from pctl_cfg() to pctl_start() which runs right afterwards. Can we instead not just call pctl_start() from within pctl_cfg() (at the end), so that this can just be a local passed along as a parameter?