build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56339 )
Change subject: asrock/e3c246d4i: Add board ......................................................................
Patch Set 1:
(6 comments)
File src/mainboard/asrock/e3c246d4i/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124309): https://review.coreboot.org/c/coreboot/+/56339/comment/8f24ed82_f553744b PS1, Line 8: the hardware starting from closest to the cpu. */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124309): https://review.coreboot.org/c/coreboot/+/56339/comment/486ff209_5595a7d5 PS1, Line 8: the hardware starting from closest to the cpu. */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124309): https://review.coreboot.org/c/coreboot/+/56339/comment/a63caf28_7b9913c2 PS1, Line 10: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124309): https://review.coreboot.org/c/coreboot/+/56339/comment/3dbf534e_ecc338c1 PS1, Line 15: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124309): https://review.coreboot.org/c/coreboot/+/56339/comment/748a3ba0_305812cc PS1, Line 20: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124309): https://review.coreboot.org/c/coreboot/+/56339/comment/bd9bf3f4_e5ddf532 PS1, Line 25: { that open brace { should be on the previous line
-
build bot (Jenkins) (Code Review)