Attention is currently required from: Paul Menzel, Rob Barnes, Karthik Ramasubramanian.
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60328 )
Change subject: mb/google/guybrush/var/dewatt: disable unused PCIe clock setting
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60328/comment/f15be6b1_8496aec0
PS1, Line 9: Disable unused PCIe GPP_CLK1 and GPP_CLK2 for dewatt.
Just for correctness, or does this fix some problem? The source is the schematics?
For correctness, unused with dewatt chematics.
Patchset:
PS1:
GPP_CLK1 is for SD and GPP_CLK2 is for WWAN on guybrush right? Can you add this to the commit messag […]
Yes. Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If449453bc60ed41e104346429babc06a73acef64
Gerrit-Change-Number: 60328
Gerrit-PatchSet: 2
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 27 Dec 2021 11:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment