Attention is currently required from: Kun Liu, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81817?usp=email )
Change subject: mb/google/brox: Create lotso variant ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brox/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/81817/comment/f0c7019c_bdf1d02f : PS3, Line 13: select BOARD_GOOGLE_BA Move this out of this file and add as: ``` config BOARD_GOOGLE_LOTSO select BOARD_GOOGLE_BASEBOARD_BROX ```
in Kconfig file.
File src/mainboard/google/brox/variants/lotso/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81817/comment/1549d6a8_5952ffa8 : PS3, Line 1: bootblock-y += gpio.c Please add SPDX License Identifier for the makefile. ``` ## SPDX-License-Identifier: GPL-2.0-only ```