Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34596 )
Change subject: sb/intel/common/spi: Fix opmenu setup ......................................................................
sb/intel/common/spi: Fix opmenu setup
Remove a spurious reference: the `optype` field is already the pointer we want.
Change-Id: I65eb3a519db9037c84750c5d40e3f19a1e360361 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/southbridge/intel/common/spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/34596/1
diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c index 3244808..0095dd9 100644 --- a/src/southbridge/intel/common/spi.c +++ b/src/southbridge/intel/common/spi.c @@ -1081,7 +1081,7 @@ optype |= (spi_config.ops[i].type & 3) << (i * 2); writeb_(spi_config.ops[i].op, &cntlr->opmenu[i]); } - writew_(optype, &cntlr->optype); + writew_(optype, cntlr->optype); }
__weak void intel_southbridge_override_spi(struct intel_swseq_spi_config *spi_config)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34596 )
Change subject: sb/intel/common/spi: Fix opmenu setup ......................................................................
Patch Set 1: Code-Review+1
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34596 )
Change subject: sb/intel/common/spi: Fix opmenu setup ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34596 )
Change subject: sb/intel/common/spi: Fix opmenu setup ......................................................................
sb/intel/common/spi: Fix opmenu setup
Remove a spurious reference: the `optype` field is already the pointer we want.
Change-Id: I65eb3a519db9037c84750c5d40e3f19a1e360361 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/34596 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/southbridge/intel/common/spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c index 3244808..0095dd9 100644 --- a/src/southbridge/intel/common/spi.c +++ b/src/southbridge/intel/common/spi.c @@ -1081,7 +1081,7 @@ optype |= (spi_config.ops[i].type & 3) << (i * 2); writeb_(spi_config.ops[i].op, &cntlr->opmenu[i]); } - writew_(optype, &cntlr->optype); + writew_(optype, cntlr->optype); }
__weak void intel_southbridge_override_spi(struct intel_swseq_spi_config *spi_config)
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)