Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Krystian Hebel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68747 )
Change subject: [WIP] security/tpm: add TPM log format as per 1.2 spec ......................................................................
Patch Set 3:
(5 comments)
File src/security/tpm/tpm12_log_serialized.h:
https://review.coreboot.org/c/coreboot/+/68747/comment/8214dc5a_9b442c3b PS2, Line 11: TCPA_DIGEST_MAX_LENGTH
`TCPA_DIGEST_LENGTH`, there can be no other.
Done
https://review.coreboot.org/c/coreboot/+/68747/comment/de80cb93_12656432 PS2, Line 13: #define TCPA_PCR_HASH_LEN 10
What is this for?
Removed.
https://review.coreboot.org/c/coreboot/+/68747/comment/2056c9fb_74031846 PS2, Line 22: char name[TCPA_PCR_HASH_NAME];
Specification doesn't precise that this is a name, just data. […]
I know, but if don't do agile log right, why would this be implemented correctly? It's done like coreboot-format which uses `name` and `char` and code in `tspi/crtm.c` relies on common structure/fields naming. I used this argument in that issue.
File src/security/tpm/tspi.h:
https://review.coreboot.org/c/coreboot/+/68747/comment/ae3bba50_75785772 PS2, Line 13: #include "tpm12_log_serialized.h"
May be worth moving to `commonlib`
It's not useful there, you can't include multiple `*_log_serialized.h` because of redefinitions.
File src/security/tpm/tspi/log-tpm12.c:
https://review.coreboot.org/c/coreboot/+/68747/comment/86ff57c3_5e41964e PS2, Line 5: then
`than`
Done
-
Sergii Dmytruk (Code Review)