Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61315 )
Change subject: drivers/intel/usb4/retimer: Use usb4_retimer_scope replace dev path ......................................................................
drivers/intel/usb4/retimer: Use usb4_retimer_scope replace dev path
Without acpi name, acpi_device_path will return NULL. <NULL>: Intel USB4 Retimer at GENERIC: 0.0 Replace with usb4_retimer_scope for the identify.
BUG=b:215742472 TEST=show below meaasge in coreboot log _SB.PCI0.TMD0.HR : Intel USB4 Retimer at GENERIC: 0.0 _SB.PCI0.TMD1.HR : Intel USB4 Retimer at GENERIC: 0.0
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Idfa8b204894409b11936e5f221c218daa206cc02 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61315 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/drivers/intel/usb4/retimer/retimer.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 8a20ebe..4e4a92c 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -415,7 +415,7 @@ acpigen_pop_len(); /* Host Router */ acpigen_pop_len(); /* Scope */
- printk(BIOS_INFO, "%s: %s at %s\n", acpi_device_path(dev), dev->chip_ops->name, + printk(BIOS_INFO, "%s.HR: %s at %s\n", usb4_retimer_scope, dev->chip_ops->name, dev_path(dev)); }