Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85613?usp=email )
Change subject: soc/mediatek/mt8196: Add pwrsel driver
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85613/comment/b20e5b96_e8925264?usp... :
PS1, Line 9:
is
File src/soc/mediatek/mt8196/include/soc/mtk_pwrsel.h:
https://review.coreboot.org/c/coreboot/+/85613/comment/47241ebc_e295a850?usp... :
PS1, Line 8: 0x0
One more tab to align with `0x04A4` below.
File src/soc/mediatek/mt8196/mtk_pwrsel.c:
https://review.coreboot.org/c/coreboot/+/85613/comment/85f56ace_a582b6d5?usp... :
PS1, Line 15: (
remove
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85613?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1b8588810fdad5c675dee865627337269b57d18
Gerrit-Change-Number: 85613
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 17 Dec 2024 08:15:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No