Attention is currently required from: Martin Roth, Matt DeVillier. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61620 )
Change subject: payloads/tianocore: Rework Makefile ......................................................................
Patch Set 20:
(2 comments)
File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/61620/comment/dc83d9fe_9bcd7c55 PS20, Line 139: $(obj)/UEFIPAYLOAD.fd
${CONFIG_PAYLOAD_FILE} ?
Done
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/61620/comment/922d82b4_7c11c155 PS20, Line 146: */
Any reason this change is needed? I think it might be better to keep the directories specific. […]
As it is now variable, if you change config's halfway through, the original directory wouldn't be removed. I'm happy to revert it, I guess it's safer - but might be worth asking Matt as he's the one who switches edk2 repo's ;)
Could hardcode known edk2 repo's (tianocore mrchromebox 9elements)?
-
Sean Rhodes (Code Review)