Attention is currently required from: Paul Menzel, Ricky Chang.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62638 )
Change subject: mb/google/brya/variants/felwinter: Fix stylus UI behavior bug
......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62638/comment/c6b9b1d9_5de622f3
PS1, Line 7: Fixed
Imperative mood: Fix
Done
https://review.coreboot.org/c/coreboot/+/62638/comment/c017748f_3753b0d8
PS1, Line 8:
Maybe mention what the actual issue is? (2 issues) […]
Done
https://review.coreboot.org/c/coreboot/+/62638/comment/cf79b218_ce875de1
PS1, Line 9: Fixed
Fix
Done
https://review.coreboot.org/c/coreboot/+/62638/comment/bca6ca46_b600ef8d
PS1, Line 10: Configuring
Configure
Done
https://review.coreboot.org/c/coreboot/+/62638/comment/28a025c1_1335a91f
PS1, Line 10: - Configuring GPP_A7 as "ACPI_GPIO_INPUT_ACTIVE_LOW".
: - Change wakeup_event_action from ASSERTED to DEASSERTED.
Why? What is the source?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f5e2992584d759eb1a559684d1cda08c7cbe3f2
Gerrit-Change-Number: 62638
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Ricky Chang
rickytlchang@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ricky Chang
rickytlchang@google.com
Gerrit-Comment-Date: Tue, 08 Mar 2022 02:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment