Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Grzegorz Bernacki, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74267 )
Change subject: soc/amd/mendocino: Add Kconfig option to generate manifest
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/mendocino/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74267/comment/cb3d61c3_95b900fc
PS3, Line 265: $(OPT_MANIFEST) \
In all three cases the manifest file looks exactly the same way
It may be true, but it is not necessarily the same for the devices in the field which go through firmware update.
I would need to create 3 different files under different names to make it work,
Yeah, that is create. It has to be 3 different files - one for each slot and then finally add them into the CBFS of the concerned slot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13c9d322735e0979484b120c665fb100cf187eab
Gerrit-Change-Number: 74267
Gerrit-PatchSet: 3
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 19 Apr 2023 15:05:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Grzegorz Bernacki
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment