Attention is currently required from: Cliff Huang, Furquan Shaikh, Sridhar Siricilla, Bernardo Perez Priego.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55989 )
Change subject: cbfstool: Add helper function `buffer_from_file_aligned_size`
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS12:
not sure if i'm misinterpreting what this is supposed to do or what it does, but shouldn't this be granularity instead of alignment? alignment is about the beginning of the section
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad3430d476abcdad850505ac50e36cd5d5deecb4
Gerrit-Change-Number: 55989
Gerrit-PatchSet: 12
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Mon, 11 Oct 2021 21:48:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment