Change in coreboot[master]: soc/intel/alderlake: Check clkreq overlap - coreboot-gerrit

4 Jan 2022


      Attention is currently required from: Kane Chen, Tim Wawrzynczak, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60401 )
Change subject: soc/intel/alderlake: Check clkreq overlap
......................................................................
Patch Set 5: -Code-Review
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60401/comment/4bd8e754_3aba5f7f 
PS5, Line 51: static
...
Hold on, we don't want this to be a static variable, otherwise it will keep its value between the tw […]
ahh, yes. valid point. why we need this variable to be static. its just a bit wise for RPs.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60401
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f701a19118f4702c227b17e43b6551591d9b344
Gerrit-Change-Number: 60401
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Kane Chen kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 04 Jan 2022 15:40:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment