Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36285 )
Change subject: soc/mediatek/mt8183: Correct continuation line indent ......................................................................
soc/mediatek/mt8183: Correct continuation line indent
BRANCH=kukui BUG=none TEST=emerge-kukui coreboot
Change-Id: I9d01d24d3494f2eb28cfb411e13adf3b6717d191 Signed-off-by: Yu-Ping Wu yupingso@google.com --- M src/soc/mediatek/mt8183/dramc_pi_basic_api.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/36285/1
diff --git a/src/soc/mediatek/mt8183/dramc_pi_basic_api.c b/src/soc/mediatek/mt8183/dramc_pi_basic_api.c index 5901f42..d4a1d59 100644 --- a/src/soc/mediatek/mt8183/dramc_pi_basic_api.c +++ b/src/soc/mediatek/mt8183/dramc_pi_basic_api.c @@ -88,12 +88,12 @@ imp_cal_result = (read32(&ch[0].phy_nao.misc_phy_rgs_cmd) >> 24) & 0x1; dramc_dbg("1. OCD DRVP=%d CALOUT=%d\n", - impx_drv, imp_cal_result); + impx_drv, imp_cal_result);
if (imp_cal_result == 1 && DRVP_result == 0xff) { DRVP_result = impx_drv; dramc_dbg("1. OCD DRVP calibration OK! DRVP=%d\n", - DRVP_result); + DRVP_result); break; } } @@ -116,12 +116,12 @@ imp_cal_result = (read32(&ch[0].phy_nao.misc_phy_rgs_cmd) >> 24) & 0x1; dramc_dbg("3. OCD ODTN=%d CALOUT=%d\n", - impx_drv, imp_cal_result); + impx_drv, imp_cal_result);
if (imp_cal_result == 0 && ODTN_result == 0xff) { ODTN_result = impx_drv; dramc_dbg("3. OCD ODTN calibration OK! ODTN=%d\n", - ODTN_result); + ODTN_result); break; } }
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36285 )
Change subject: soc/mediatek/mt8183: Correct continuation line indent ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36285 )
Change subject: soc/mediatek/mt8183: Correct continuation line indent ......................................................................
Patch Set 1: Code-Review+2
Trivial change and split out from CB:35767 (where it was reviewed and discussed for longer), so taking the liberty not to wait 24 hours.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36285 )
Change subject: soc/mediatek/mt8183: Correct continuation line indent ......................................................................
soc/mediatek/mt8183: Correct continuation line indent
BRANCH=kukui BUG=none TEST=emerge-kukui coreboot
Change-Id: I9d01d24d3494f2eb28cfb411e13adf3b6717d191 Signed-off-by: Yu-Ping Wu yupingso@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36285 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8183/dramc_pi_basic_api.c 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Hung-Te Lin: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8183/dramc_pi_basic_api.c b/src/soc/mediatek/mt8183/dramc_pi_basic_api.c index 5901f42..d4a1d59 100644 --- a/src/soc/mediatek/mt8183/dramc_pi_basic_api.c +++ b/src/soc/mediatek/mt8183/dramc_pi_basic_api.c @@ -88,12 +88,12 @@ imp_cal_result = (read32(&ch[0].phy_nao.misc_phy_rgs_cmd) >> 24) & 0x1; dramc_dbg("1. OCD DRVP=%d CALOUT=%d\n", - impx_drv, imp_cal_result); + impx_drv, imp_cal_result);
if (imp_cal_result == 1 && DRVP_result == 0xff) { DRVP_result = impx_drv; dramc_dbg("1. OCD DRVP calibration OK! DRVP=%d\n", - DRVP_result); + DRVP_result); break; } } @@ -116,12 +116,12 @@ imp_cal_result = (read32(&ch[0].phy_nao.misc_phy_rgs_cmd) >> 24) & 0x1; dramc_dbg("3. OCD ODTN=%d CALOUT=%d\n", - impx_drv, imp_cal_result); + impx_drv, imp_cal_result);
if (imp_cal_result == 0 && ODTN_result == 0xff) { ODTN_result = impx_drv; dramc_dbg("3. OCD ODTN calibration OK! ODTN=%d\n", - ODTN_result); + ODTN_result); break; } }
-
Hung-Te Lin (Code Review) -
Patrick Georgi (Code Review)
-
Yu-Ping Wu (Code Review)