Attention is currently required from: Arthur Heymans, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu.
Felix Singer has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/83327?usp=email )
Change subject: mb/intel/beechnutcity_crb: Update SMBIOS type 0,1,2,3 info
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/intel/beechnutcity_crb/Kconfig:
https://review.coreboot.org/c/coreboot/+/83327/comment/3a27d903_1eebb2ea?usp... :
PS1, Line 29: config MAINBOARD_VENDOR
: string
: default "Intel Corporation"
Not needed. The vendor is configured in the Kconfig from mainboard/intel.
https://review.coreboot.org/c/coreboot/+/83327/comment/8f014d62_41721835?usp... :
PS1, Line 37: config MAINBOARD_SERIAL_NUMBER
: string
: d
Seems superfluous too. A dummy serial number is configured in the top-level Kconfig at src/Kconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83327?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8a7d4958171df121e2cd3acb3a71554c695d64ab
Gerrit-Change-Number: 83327
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 03 Jul 2024 11:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No