Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41102 )
Change subject: memrange: constify memranges_is_empty() ......................................................................
memrange: constify memranges_is_empty()
memranges_is_empty() doesn't need to manipulate the object. Mark the parameter as const.
Change-Id: I89f4ec404c144eac8d2900945a1ccaf5cc4f88bb Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/include/memrange.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/41102/1
diff --git a/src/include/memrange.h b/src/include/memrange.h index 2579f20..deb8c1e 100644 --- a/src/include/memrange.h +++ b/src/include/memrange.h @@ -69,7 +69,7 @@ r->tag = new_tag; }
-static inline bool memranges_is_empty(struct memranges *ranges) +static inline bool memranges_is_empty(const struct memranges *ranges) { return ranges->entries == NULL; }
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41102 )
Change subject: memrange: constify memranges_is_empty() ......................................................................
Patch Set 1: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41102 )
Change subject: memrange: constify memranges_is_empty() ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41102 )
Change subject: memrange: constify memranges_is_empty() ......................................................................
memrange: constify memranges_is_empty()
memranges_is_empty() doesn't need to manipulate the object. Mark the parameter as const.
Change-Id: I89f4ec404c144eac8d2900945a1ccaf5cc4f88bb Signed-off-by: Aaron Durbin adurbin@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/41102 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/memrange.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/src/include/memrange.h b/src/include/memrange.h index 2579f20..deb8c1e 100644 --- a/src/include/memrange.h +++ b/src/include/memrange.h @@ -69,7 +69,7 @@ r->tag = new_tag; }
-static inline bool memranges_is_empty(struct memranges *ranges) +static inline bool memranges_is_empty(const struct memranges *ranges) { return ranges->entries == NULL; }
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41102 )
Change subject: memrange: constify memranges_is_empty() ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3261 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3260 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3259 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3258
Please note: This test is under development and might not be accurate at all!