Change in coreboot[master]: driver/i2c/sx9360: Add pre-charge resistance setting - coreboot-gerrit

22 Mar 2022


      Attention is currently required from: Paul Menzel, Gwendal Grignou.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62842 )
Change subject: driver/i2c/sx9360: Add pre-charge resistance setting
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62842/comment/190f2759_8f6379eb 
PS3, Line 14: 
is there a BUG?
File src/drivers/i2c/sx9360/chip.h:
https://review.coreboot.org/c/coreboot/+/62842/comment/80e6537d_cddf4def 
PS1, Line 39: /* Precharge input resistance. Driver default: 0. */
...
Looks like the field is 5 bits, and the unit is just ohms? can we add that information here?
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62842
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I197b88d92784015b94c836dc128bacf3f1ef5b62
Gerrit-Change-Number: 62842
Gerrit-PatchSet: 3
Gerrit-Owner: Gwendal Grignou gwendal@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Gwendal Grignou gwendal@chromium.org
Gerrit-Comment-Date: Tue, 22 Mar 2022 19:11:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment