Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37798 )
Change subject: util/nvramtool: Create nvramtool object directories earlier ......................................................................
util/nvramtool: Create nvramtool object directories earlier
The existing rule created a potential race condition between creating the directory and putting files in there, so use our existing infrastructure for directory creation instead.
Change-Id: If52a9f558c7d9ce85f71ba53232594699c9d357a Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/nvramtool/Makefile.inc 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/37798/1
diff --git a/util/nvramtool/Makefile.inc b/util/nvramtool/Makefile.inc index 48f6d86..6974289 100644 --- a/util/nvramtool/Makefile.inc +++ b/util/nvramtool/Makefile.inc @@ -36,8 +36,7 @@ nvramtoolobj += win32mmap.o endif
-$(objutil)/nvramtool $(objutil)/nvramtool/accessors $(objutil)/nvramtool/cli: - mkdir -p $@ +additional-dirs += $(objutil)/nvramtool/accessors $(objutil)/nvramtool/cli
$(objutil)/nvramtool/%.o: $(top)/util/nvramtool/%.c printf " HOSTCC $(subst $(objutil)/,,$(@))\n"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37798 )
Change subject: util/nvramtool: Create nvramtool object directories earlier ......................................................................
Patch Set 1: Code-Review+1
Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37798 )
Change subject: util/nvramtool: Create nvramtool object directories earlier ......................................................................
Patch Set 1: Code-Review+1
Sorry, don't have +2 rights yet still
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37798 )
Change subject: util/nvramtool: Create nvramtool object directories earlier ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37798 )
Change subject: util/nvramtool: Create nvramtool object directories earlier ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37798 )
Change subject: util/nvramtool: Create nvramtool object directories earlier ......................................................................
util/nvramtool: Create nvramtool object directories earlier
The existing rule created a potential race condition between creating the directory and putting files in there, so use our existing infrastructure for directory creation instead.
Change-Id: If52a9f558c7d9ce85f71ba53232594699c9d357a Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37798 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Jett Rink jettrink@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/nvramtool/Makefile.inc 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Jett Rink: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/util/nvramtool/Makefile.inc b/util/nvramtool/Makefile.inc index 48f6d86..6974289 100644 --- a/util/nvramtool/Makefile.inc +++ b/util/nvramtool/Makefile.inc @@ -36,8 +36,7 @@ nvramtoolobj += win32mmap.o endif
-$(objutil)/nvramtool $(objutil)/nvramtool/accessors $(objutil)/nvramtool/cli: - mkdir -p $@ +additional-dirs += $(objutil)/nvramtool/accessors $(objutil)/nvramtool/cli
$(objutil)/nvramtool/%.o: $(top)/util/nvramtool/%.c printf " HOSTCC $(subst $(objutil)/,,$(@))\n"
-
Angel Pons (Code Review) -
Jett Rink (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)