Attention is currently required from: Ravi Kumar Bokka, Shelley Chen, Hung-Te Lin, Nico Huber, Paul Menzel, Rex-BC Chen, Julius Werner, Arthur Heymans, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63251 )
Change subject: coreboot_tables: Add PCIe info to coreboot table
......................................................................
Patch Set 19:
(1 comment)
Patchset:
PS9:
As far as I'm aware this is their current draft patch: CB:57615. […]
Ravi, could you answer the following questions?
1. Does qualcomm's pcie implementation has the concept of "controller base address"? Does it make sense to set ctrl_base = 0x40000000, atu_base = ctrl_base + 0x1000, mmio_base = ctrl_base + 0x100000?
2. Are atu_base and mmio_base expected to be different for each qualcomm SoC? What about the offsets 0x1000 and 0x100000?
3. Where does the MMIO_LENGTH value (0x100000 = 1MB) come from? Is it likely to be changed for future qualcomm SoCs? Can this value be calculated somehow (for example, by 4KB * devices_per_bus * funcs_per_device = 4KB * 32 * 8)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63251
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cdce21efc66aa441ec077e6fc1d5d1c6a9aafb0
Gerrit-Change-Number: 63251
Gerrit-PatchSet: 19
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Thu, 21 Apr 2022 07:27:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-MessageType: comment