Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36079 )
Change subject: mb/supermicro/x11-lga1151-series: Fix SLP assertion width ......................................................................
mb/supermicro/x11-lga1151-series: Fix SLP assertion width
The soft reboot wasn't working when issued from OS. Use the same SLP assertion width values as vendor does.
Tested on Supermicro X11SSH-TF: The reboot now works when issued from OS.
Change-Id: I437f0f03209b4f00b08e738c37ef5adc96b90226 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/36079/1
diff --git a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb index a5ff0c5..65e549b 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb +++ b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb @@ -4,6 +4,7 @@ register "deep_s5_enable_ac" = "0" register "deep_s5_enable_dc" = "0" register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN" + register "s0ix_enable" = "0"
# Enable "Intel Speed Shift Technology" register "speed_shift_enable" = "1" @@ -99,10 +100,12 @@ register "serirq_mode" = "SERIRQ_CONTINUOUS"
# Enabling SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch - register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_50MS" + register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_60US" register "PmConfigSlpS4MinAssert" = "SLP_S4_MIN_ASSERT_4S" - register "PmConfigSlpSusMinAssert" = "SLP_SUS_MIN_ASSERT_4S" - register "PmConfigSlpAMinAssert" = "SLP_A_MIN_ASSERT_2S" + register "PmConfigSlpSusMinAssert" = "SLP_SUS_MIN_ASSERT_0MS" + register "PmConfigSlpAMinAssert" = "SLP_A_MIN_ASSERT_0MS" + register "PmConfigPwrBtnOverridePeriod" = "0" + register "PmConfigPwrCycDur" = "2"
# VR Settings Configuration for 4 Domains # ICC_MAX = 0 (Auto)
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36079 )
Change subject: mb/supermicro/x11-lga1151-series: Fix SLP assertion width ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36079 )
Change subject: mb/supermicro/x11-lga1151-series: Fix SLP assertion width ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36079/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36079/1//COMMIT_MSG@12 PS1, Line 12: Tested on Supermicro X11SSH-TF: needs testing / register review on x11ssm. add me as reviewer for future x11-global changes, please!
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36079 )
Change subject: mb/supermicro/x11-lga1151-series: Fix SLP assertion width ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 101: # Enabling SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch : register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_50MS" : register "PmConfigSlpS4MinAssert" = "SLP_S4_MIN_ASSERT_4S" : register "PmConfigSlpSusMinAssert" = "SLP_SUS_MIN_ASSERT_4S" : register "PmConfigSlpAMinAssert" = "SLP_A_MIN_ASSERT_2S" at least on x11ssm, all these values match vendor settings; can you share a inteltool dump with CB:35189, please? maybe those values differ for x11ssh-tf. then we'd need to move those settings to the variants overridetree
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 7: register "s0ix_enable" = "0" already defaults to "0", not needed
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 107: PmConfigPwrBtnOverridePeriod not needed. a) this has nothing to do with Slp but sets the time you need to press the power button to do a global reset and b) this already defaults to 0, which is 4s.
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 108: PmConfigPwrCycDur why is this needed? this is PWR_CYC_DUR; vendor sets default (4-5 secs = value 0) on x11ssm
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36079 )
Change subject: mb/supermicro/x11-lga1151-series: Fix SLP assertion width ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 7: register "s0ix_enable" = "0"
already defaults to "0", not needed
on x11ssm SLP_S0 is enabled; we may need to move this to the variants, if this really differs
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36079 )
Change subject: mb/supermicro/x11-lga1151-series: Fix SLP assertion width ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36079/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36079/1//COMMIT_MSG@12 PS1, Line 12: Tested on Supermicro X11SSH-TF:
needs testing / register review on x11ssm. […]
Done
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 7: register "s0ix_enable" = "0"
on x11ssm SLP_S0 is enabled; we may need to move this to the variants, if this really differs
see cb:36141
Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36079 )
Change subject: mb/supermicro/x11-lga1151-series: Fix SLP assertion width ......................................................................
Abandoned
Works without this change.
-
Michael Niewöhner (Code Review) -
Patrick Rudolph (Code Review)
-
Philipp Deppenwiese (Code Review)