Attention is currently required from: Martin L Roth.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 )
Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup
......................................................................
Patch Set 22:
(1 comment)
File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68820/comment/343eb3ea_233eed44
PS22, Line 336: gpio_output(GPP_B11, 1); /* PCH_FP_PWR_EN */
: mdelay(3);
: gpio_output(GPP_C9, 1); /* FP_RST_ODL */
Not a fan of adding the delay. […]
We've dropped the 50ms delay and simply will rely on the inherit 150ms we can get without it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68820
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21eb85dc11e0ea0eb5de8a6092b01663d3c3df91
Gerrit-Change-Number: 68820
Gerrit-PatchSet: 22
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Mon, 09 Jan 2023 19:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment