Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29474 )
Change subject: device: Use scan_static_bus() over scan_lpc_bus() ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/29474/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/29474/1//COMMIT_MSG@7 PS1, Line 7: device/root_device: Scan bridges on LPC bus too
Could you please provide a reasoning in the commit description as well as what sort of bridges exist […]
Done
https://review.coreboot.org/c/coreboot/+/29474/5/src/device/root_device.c File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/29474/5/src/device/root_device.c@66 PS5, Line 66: void scan_lpc_bus(struct device *bus)
Yep (the former sneaked into a rebase). I'll try to consolidate this.
Done
https://review.coreboot.org/c/coreboot/+/29474/5/src/device/root_device.c@10... PS5, Line 105: link->secondary = ++bus_max;
Should be needed for dev_find_slot_on_smbus() only? Rename to smbus_idx and set conditionally on pat […]
Unrelated (will hopefully vanish after the next code removal).
https://review.coreboot.org/c/coreboot/+/29474/5/src/device/root_device.c@12... PS5, Line 126: void scan_smbus(struct device *bus)
I kind of like that we assign . […]
Won't do, see reasoning in parent change.
-
Nico Huber (Code Review)