Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63697 )
Change subject: drivers/intel/dptf: Add support for PROP method ......................................................................
drivers/intel/dptf: Add support for PROP method
Add PROP method under _SB.DPTF.TPWR scope which will return static worst case rest of platform power in miliWatts.
This value is static, which has to configured from devicetree of overridetree for each platform
BUG=b:205928013 TEST=Build, boot brya0 and dump SSDT to check PROP method
Scope (_SB) { Device (DPTF) { Device (TPWR) { Method (PROP, 0, Serialized) { Return (XXXX) } } } }
Signed-off-by: Varshit B Pandya varshit.b.pandya@intel.com Change-Id: I1415d2a9eb55cfadc3a7b41b53ecbec657002759 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63697 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c 2 files changed, 17 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/drivers/intel/dptf/chip.h b/src/drivers/intel/dptf/chip.h index 59b1e25..060f196 100644 --- a/src/drivers/intel/dptf/chip.h +++ b/src/drivers/intel/dptf/chip.h @@ -59,6 +59,9 @@ struct { uint32_t oem_variables[DPTF_OEM_VARIABLE_COUNT]; } oem_data; + + /* Rest of platform Power */ + uint32_t prop; };
#endif /* _DRIVERS_INTEL_DPTF_CHIP_H_ */ diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 27c7133..3cfd23c 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -372,7 +372,8 @@ acpigen_write_device_end(); /* TPCH Device */ }
-static void write_create_tpwr(const struct dptf_platform_info *platform_info) +static void write_create_tpwr(const struct drivers_intel_dptf_config *config, + const struct dptf_platform_info *platform_info) { acpigen_write_device("TPWR"); acpigen_write_name("_HID"); @@ -382,12 +383,21 @@ acpigen_write_name_string("_STR", DEFAULT_POWER_STR); acpigen_write_name_integer("PTYP", DPTF_GENERIC_PARTICIPANT_TYPE_POWER); acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); + + /* PROP method */ + if(config->prop != 0) { + acpigen_write_method_serialized("PROP", 0); + acpigen_emit_byte(RETURN_OP); + acpigen_write_integer(config->prop); + acpigen_pop_len(); /* Method PROP */ + } acpigen_write_device_end(); /* TPWR Power Participant Device */ }
-static void write_tpwr_methods(const struct dptf_platform_info *platform_info) +static void write_tpwr_methods(const struct drivers_intel_dptf_config *config, + const struct dptf_platform_info *platform_info) { - write_create_tpwr(platform_info); + write_create_tpwr(config, platform_info); }
static void write_create_tbat(const struct dptf_platform_info *platform_info) @@ -449,7 +459,7 @@ write_tpch_methods(platform_info);
if (CONFIG(DRIVERS_INTEL_DPTF_SUPPORTS_TPWR)) - write_tpwr_methods(platform_info); + write_tpwr_methods(config, platform_info);
if (CONFIG(DRIVERS_INTEL_DPTF_SUPPORTS_TBAT)) write_tbat_methods(platform_info);