Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47195 )
Change subject: soc/intel/cnl: replace the remaints of HeciEnabled by device state in dt
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47195/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47195/8//COMMIT_MSG@11
PS8, Line 11: gets
: always gets
only one `gets` is enough
https://review.coreboot.org/c/coreboot/+/47195/8/src/soc/intel/cannonlake/sm...
File src/soc/intel/cannonlake/smihandler.c:
https://review.coreboot.org/c/coreboot/+/47195/8/src/soc/intel/cannonlake/sm...
PS8, Line 23: CONFIG(HECI_DISABLE_USING_SMM)
I'd rather place this check before the pcidev_path_on_root() call:
if (!CONFIG(HECI_DISABLE_USING_SMM))
return;
This is merely for optimization purposes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4cca9099b9aa3434552a41fbafca7cf6a0dd0eb
Gerrit-Change-Number: 47195
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Nov 2020 09:38:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment